RE: [RFC][PATCH] Generic Hotkey driver interface

Yu, Luming
2004-11-10T09:18:07Z

Alex,

My arguments for keeping hotkey or video driver in kernel could be:

1. Generically speaking, hotkey driver should Not be limited
in ACPI area. We could enhance this driver to be able to intercept
generic keyboard/mouse or other input device events. Also we need
to keep handling of hotkey unified in system wide.

2. Less dependency.

Anyway, technically speaking, your approach of implementing hotkey,
video or others acpi stuff in user space is doable, but, it will isolate
hotkey , video .. from other device drivers and kernel, which could be useful
or even crucial to features unknow to me right now.

So, I vote for kernel space hotkey driver at current stage just for the
possible of expansibility.

Thanks
Luming

>-----Original Message-----
>From: Alex Williamson [mailto:alex.williamson-VXdhtT5mjnY@public.gmane.org]
>Sent: 2004年11月10日 0:13
>To: Yu, Luming
>Cc: Borislav Deianov; Karol Kozimor; Hiroshi Miura; Julien
>Lerouge; Brown, Len; acpi-devel
>Subject: Re: [RFC][PATCH] Generic Hotkey driver interface
>
>Luming,
>
> Have you considered trying to implement this as a userspace
>daemon on
>top of dev_acpi? I believe I'm exporting all the of the ACPI
>interfaces
>you'd need to do this. The acpivideo tool (available along w/ the
>latest dev_acpi) does something similar in setting up a notify handler
>on the graphics device, and receiving hotkey events. The hooks are
>already there to allow userspace to generate an ACPI event as
>well. I'd
>be interested in any feedback you have on dev_acpi should you
>investigate this approach. Thanks,
>
> Alex
>
>On Tue, 2004-11-09 at 23:25 +0800, Yu, Luming wrote:
>> To consolidate the hotkey implementation in ACPI subsystem,
>> I tried to implement a generic hotkey driver under ACPI.
>> I hope you can give it a review. Thanks in advances for any
>> comments.
>>
>> The basic idea is to supply configurable interface
>> to userspace, thus user can configure the generic
>> hotkey driver to work for their specific laptop model.
>>
>> Please note, the code is trying to prove the concept
>> is feasible. So there are large room to improve, including
>> bugs need to be fixed, redundant code need to be clean up,
>> critical section need to be protected by lock or semaphore,
>> memory leak need to be fix up, interfaces need to be revised.
>>
>> The code is inspired by Karol Kozimor, Borislav Deianov,
>> Hiroshi Miura, Julien Lerouge, Alex Williamson, and Len.
>>
>> Thanks,
>> Luming
>
>--
>Alex Williamson HP Linux & Open Source Lab
>
>

-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.