From mboxrd@z Thu Jan 1 00:00:00 1970 From: Len Brown Subject: Re: [PATCH] Container.ko: Use kobject_hotplug() to notify user agent Date: 11 Nov 2004 03:56:47 -0500 Message-ID: <1100163407.6092.696.camel@d845pe> References: <20041110181653.A15383@unix-os.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20041110181653.A15383-39QZ/XbsZ5/mO6KZMuUCQVaTQe2KTcn/@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Anil S Keshavamurthy Cc: ACPI Developer List-Id: linux-acpi@vger.kernel.org Applied, thanks, -Len On Wed, 2004-11-10 at 21:16, Keshavamurthy Anil S wrote: > Hi Len, > Due to "hotplug_path" getting un-exported from mm3, the > container code > was breaking and was asked to use kobject_hotplug to notify user > agent. > > So I have fixed the container driver to use kobject_hotplug(). > This patch will fix the undefined "hotplug_path" warning. > > Please apply. > > --- > > linux-2.6.10-rc1-mm4-askeshav/drivers/acpi/container.c | 52 > ----------------- > 1 files changed, 3 insertions(+), 49 deletions(-) > > diff -puN drivers/acpi/container.c~container_u1_hotplug_path_fix > drivers/acpi/container.c > --- > linux-2.6.10-rc1-mm4/drivers/acpi/container.c~container_u1_hotplug_path_fix 2004-11-10 13:33:29.657947459 -0800 > +++ linux-2.6.10-rc1-mm4-askeshav/drivers/acpi/container.c > 2004-11-10 13:33:29.735095896 -0800 > @@ -133,52 +133,6 @@ acpi_container_remove(struct acpi_device > > > static int > -container_run_sbin_hotplug(struct acpi_device *device, char *action) > -{ > - char *argv[3], *envp[6], action_str[32]; > - int i, ret; > - int len; > - char pathname[ACPI_PATHNAME_MAX] = {0}; > - acpi_status status; > - char *container_str; > - struct acpi_buffer buffer = {ACPI_PATHNAME_MAX, pathname}; > - > - ACPI_FUNCTION_TRACE("container_run_sbin_hotplug"); > - > - > - status = acpi_get_name(device->handle, ACPI_FULL_PATHNAME, > &buffer); > - if (ACPI_FAILURE(status)) { > - return(-ENODEV); > - } > - > - len = strlen("CONTAINER=") + strlen(pathname) + 1; > - container_str = kmalloc(len, GFP_KERNEL); > - if (!container_str) > - return(-ENOMEM); > - > - sprintf(container_str, "CONTAINER=%s",pathname); > - sprintf(action_str, "ACTION=%s", action); > - > - i = 0; > - argv[i++] = hotplug_path; > - argv[i++] = "container"; > - argv[i] = NULL; > - > - i = 0; > - envp[i++] = "HOME=/"; > - envp[i++] = "PATH=/sbin;/bin;/usr/sbin;/usr/bin"; > - envp[i++] = action_str; > - envp[i++] = container_str; > - envp[i++] = "PLATFORM=ACPI"; > - envp[i] = NULL; > - > - ret = call_usermodehelper(argv[0], argv, envp, 0); > - > - kfree(container_str); > - return_VALUE(ret); > -} > - > -static int ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click