public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Stas Sergeev <stsp-D1TkPCJej5s@public.gmane.org>
Cc: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
	Linux kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	ACPI Developers
	<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	Shaohua Li <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: Fw: ACPI bug causes cd-rom lock-ups (2.6.10-rc2)
Date: 24 Nov 2004 17:44:27 -0500	[thread overview]
Message-ID: <1101336267.20008.5326.camel@d845pe> (raw)
In-Reply-To: <41A4CF1C.6090503-D1TkPCJej5s@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

On Wed, 2004-11-24 at 13:12, Stas Sergeev wrote:
> Hello.
> 
> Len Brown wrote:

> > Did 2.6.9 work correctly?
> Yes!

> > Any difference with CONFIG_PNP=n?
> Yes. The difference is that the problem
> disappears.

CONFIG_PNP_ACPI=n should workaround it too then, I expect.

Please apply this debug patch to the failing kernel
and send along the dmesg.  It will tell us how we
messed up the irq penalties and improperly chose
IRQ15 for a PCI device on this system.

thanks,
-Len


[-- Attachment #2: link.patch --]
[-- Type: text/plain, Size: 1437 bytes --]

===== drivers/acpi/pci_link.c 1.36 vs edited =====
--- 1.36/drivers/acpi/pci_link.c	2004-11-23 00:02:39 -05:00
+++ edited/drivers/acpi/pci_link.c	2004-11-24 17:41:15 -05:00
@@ -468,6 +468,17 @@
 			/* >IRQ15 */
 };
 
+void
+acpi_irq_penalty_dump(char *string)
+{
+	int i;
+
+	printk("ACPI %s: ", string);
+	for (i = 0; i < ACPI_MAX_ISA_IRQ; ++i) {
+		printk("%X ", acpi_irq_penalty[i]);
+	}
+	printk("\n");
+}
 int __init
 acpi_irq_penalty_init(void)
 {
@@ -476,6 +487,7 @@
 	int			i = 0;
 
 	ACPI_FUNCTION_TRACE("acpi_irq_penalty_init");
+	acpi_irq_penalty_dump("enter init");
 
 	/*
 	 * Update penalties to facilitate IRQ balancing.
@@ -507,6 +519,7 @@
 	/* Add a penalty for the SCI */
 	acpi_irq_penalty[acpi_fadt.sci_int] += PIRQ_PENALTY_PCI_USING;
 
+	acpi_irq_penalty_dump("exit init");
 	return_VALUE(0);
 }
 
@@ -547,6 +560,7 @@
 		irq = link->irq.possible[link->irq.possible_count - 1];
 	}
 
+acpi_irq_penalty_dump("allocate");
 	if (acpi_irq_balance || !link->irq.active) {
 		/*
 		 * Select the best IRQ.  This is done in reverse to promote
@@ -570,6 +584,7 @@
 		printk(PREFIX "%s [%s] enabled at IRQ %d\n", 
 			acpi_device_name(link->device),
 			acpi_device_bid(link->device), link->irq.active);
+acpi_irq_penalty_dump("allocated");
 	}
 
 	link->irq.initialized = 1;
@@ -789,6 +804,7 @@
 void acpi_penalize_isa_irq(int irq)
 {
 	acpi_irq_penalty[irq] += PIRQ_PENALTY_ISA_USED;
+acpi_irq_penalty_dump("isa");
 }
 
 /*

  parent reply	other threads:[~2004-11-24 22:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <41990138.7080008@aknet.ru>
     [not found] ` <41990138.7080008-D1TkPCJej5s@public.gmane.org>
2004-11-23  6:09   ` Fw: ACPI bug causes cd-rom lock-ups (2.6.10-rc2) Len Brown
2004-11-24 18:12     ` Stas Sergeev
     [not found]       ` <41A4CF1C.6090503-D1TkPCJej5s@public.gmane.org>
2004-11-24 22:44         ` Len Brown [this message]
2004-11-25 18:18           ` Stas Sergeev
     [not found]             ` <41A621DD.8060102-D1TkPCJej5s@public.gmane.org>
2004-12-01  5:41               ` Len Brown
2004-12-01  5:44                 ` Len Brown
2004-12-02 16:52                 ` Stas Sergeev
2004-12-01 20:26 matthieu castet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1101336267.20008.5326.camel@d845pe \
    --to=len.brown-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=akpm-3NddpPZAyC0@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=stsp-D1TkPCJej5s@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox