Re: Re: [PATCHES] add _CST support

Dominik Brodowski
2004-12-28T17:50:58Z

On Mon, Dec 27, 2004 at 10:27:15PM -0500, Len Brown wrote:
> On Thu, 2004-12-23 at 08:07, Pavel Machek wrote:
>
> > > C-states are enumerated C0...Cn
> > > C-state types are enumerated C1, C2, C3.
> > > I don't see any confusion in the name-space duplicates
> > > as long as you know you're talking about C-states or C-state-types.
> > >
> >
> > Unfortunately, people often don't know what they are talking about.
> > Having two things called C2 is definitely going to confuse just
> > about everyone but you...
>
> Probably we should not mess with the "well known" (hah;-) name space for
> C-states themselves (C0...Cn).
>
> Types, on the other hand, would probably be well addressed with a enum
> whose vales are 1,2,3 so if we chose to print them out they'd simply be
> a %d -- using C%d only for actual C-states themselves.
>
> would that be better?

I _still_ favour using C0 to C3 for the types, as the meaning of this is
probably better known [e.g. the implications of C3 to bus mastering], and
invent something new (like I0 to In for idle states?) and hope the ACPI
specification group will like this naming and "clarify" it in ACPI 2./3.x

However, I guess we do have to live with a broken ACPI specification in this
regard... But it is an imperfect world, after all :-)

Dominik