From: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Dominik Brodowski
<linux-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org>
Cc: ACPI Developers
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH 2/5] processor: C0, C1, C2 naming
Date: 23 Dec 2004 15:09:47 -0500 [thread overview]
Message-ID: <1103832587.4376.17.camel@d845pe> (raw)
In-Reply-To: <20041223140723.GB7973-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org>
Applied.
thanks,
-Len
On Thu, 2004-12-23 at 09:07, Dominik Brodowski wrote:
> Current policy is to name both C-state-types and the actual C-States
> "C[0-n]". Follow this rule...
>
> Signed-off-by: Dominik Brodowski <linux-JhLEnvuH02M@public.gmane.org>
> ---
>
> drivers/acpi/processor_idle.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> Index: linux-2.6.10-rc3+bk-acpi/drivers/acpi/processor_idle.c
> ===================================================================
> --- linux-2.6.10-rc3+bk-acpi.orig/drivers/acpi/processor_idle.c
> 2004-12-23 14:24:13.328939202 +0100
> +++ linux-2.6.10-rc3+bk-acpi/drivers/acpi/processor_idle.c
> 2004-12-23 14:25:23.854099002 +0100
> @@ -834,7 +834,7 @@
> if (!pr)
> goto end;
>
> - seq_printf(seq, "active state: %d\n"
> + seq_printf(seq, "active state: C%d\n"
> "max_cstate: C%d\n"
> "bus master activity: %08x\n",
> pr->power.state ? pr->power.state -
> pr->power.states : 0,
> @@ -844,7 +844,7 @@
> seq_puts(seq, "states:\n");
>
> for (i = 1; i <= pr->power.count; i++) {
> - seq_printf(seq, " %c%d: ",
> + seq_printf(seq, " %cC%d: ",
> (&pr->power.states[i] == pr->power.state?'*':'
> '), i);
>
> if (!pr->power.states[i].valid) {
> @@ -868,18 +868,18 @@
> }
>
> if (pr->power.states[i].promotion.state)
> - seq_printf(seq, "promotion[%d] ",
> + seq_printf(seq, "promotion[C%d] ",
> (pr->power.states[i].promotion.state -
> pr->power.states));
> else
> - seq_puts(seq, "promotion[-] ");
> + seq_puts(seq, "promotion[--] ");
>
> if (pr->power.states[i].demotion.state)
> - seq_printf(seq, "demotion[%d] ",
> + seq_printf(seq, "demotion[C%d] ",
> (pr->power.states[i].demotion.state -
> pr->power.states));
> else
> - seq_puts(seq, "demotion[-] ");
> + seq_puts(seq, "demotion[--] ");
>
> seq_printf(seq, "latency[%03d] usage[%08d]\n",
> pr->power.states[i].latency,
> @@ -939,7 +939,7 @@
> printk(KERN_INFO PREFIX "CPU%d (power states:",
> pr->id);
> for (i = 1; i <= pr->power.count; i++)
> if (pr->power.states[i].valid)
> - printk(" %d[C%d]", i,
> pr->power.states[i].type);
> + printk(" C%d[C%d]", i,
> pr->power.states[i].type);
> printk(")\n");
>
> if (pr->id == 0) {
>
>
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
prev parent reply other threads:[~2004-12-23 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-23 14:07 [PATCH 2/5] processor: C0, C1, C2 naming Dominik Brodowski
[not found] ` <20041223140723.GB7973-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org>
2004-12-23 20:09 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1103832587.4376.17.camel@d845pe \
--to=len.brown-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox