* [PATCH 2/5] processor: C0, C1, C2 naming
@ 2004-12-23 14:07 Dominik Brodowski
[not found] ` <20041223140723.GB7973-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Brodowski @ 2004-12-23 14:07 UTC (permalink / raw)
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
len.brown-ral2JQCrhuEAvxtiuMwx3w
Current policy is to name both C-state-types and the actual C-States
"C[0-n]". Follow this rule...
Signed-off-by: Dominik Brodowski <linux-JhLEnvuH02M@public.gmane.org>
---
drivers/acpi/processor_idle.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
Index: linux-2.6.10-rc3+bk-acpi/drivers/acpi/processor_idle.c
===================================================================
--- linux-2.6.10-rc3+bk-acpi.orig/drivers/acpi/processor_idle.c 2004-12-23 14:24:13.328939202 +0100
+++ linux-2.6.10-rc3+bk-acpi/drivers/acpi/processor_idle.c 2004-12-23 14:25:23.854099002 +0100
@@ -834,7 +834,7 @@
if (!pr)
goto end;
- seq_printf(seq, "active state: %d\n"
+ seq_printf(seq, "active state: C%d\n"
"max_cstate: C%d\n"
"bus master activity: %08x\n",
pr->power.state ? pr->power.state - pr->power.states : 0,
@@ -844,7 +844,7 @@
seq_puts(seq, "states:\n");
for (i = 1; i <= pr->power.count; i++) {
- seq_printf(seq, " %c%d: ",
+ seq_printf(seq, " %cC%d: ",
(&pr->power.states[i] == pr->power.state?'*':' '), i);
if (!pr->power.states[i].valid) {
@@ -868,18 +868,18 @@
}
if (pr->power.states[i].promotion.state)
- seq_printf(seq, "promotion[%d] ",
+ seq_printf(seq, "promotion[C%d] ",
(pr->power.states[i].promotion.state -
pr->power.states));
else
- seq_puts(seq, "promotion[-] ");
+ seq_puts(seq, "promotion[--] ");
if (pr->power.states[i].demotion.state)
- seq_printf(seq, "demotion[%d] ",
+ seq_printf(seq, "demotion[C%d] ",
(pr->power.states[i].demotion.state -
pr->power.states));
else
- seq_puts(seq, "demotion[-] ");
+ seq_puts(seq, "demotion[--] ");
seq_printf(seq, "latency[%03d] usage[%08d]\n",
pr->power.states[i].latency,
@@ -939,7 +939,7 @@
printk(KERN_INFO PREFIX "CPU%d (power states:", pr->id);
for (i = 1; i <= pr->power.count; i++)
if (pr->power.states[i].valid)
- printk(" %d[C%d]", i, pr->power.states[i].type);
+ printk(" C%d[C%d]", i, pr->power.states[i].type);
printk(")\n");
if (pr->id == 0) {
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/5] processor: C0, C1, C2 naming
[not found] ` <20041223140723.GB7973-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org>
@ 2004-12-23 20:09 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2004-12-23 20:09 UTC (permalink / raw)
To: Dominik Brodowski; +Cc: ACPI Developers
Applied.
thanks,
-Len
On Thu, 2004-12-23 at 09:07, Dominik Brodowski wrote:
> Current policy is to name both C-state-types and the actual C-States
> "C[0-n]". Follow this rule...
>
> Signed-off-by: Dominik Brodowski <linux-JhLEnvuH02M@public.gmane.org>
> ---
>
> drivers/acpi/processor_idle.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> Index: linux-2.6.10-rc3+bk-acpi/drivers/acpi/processor_idle.c
> ===================================================================
> --- linux-2.6.10-rc3+bk-acpi.orig/drivers/acpi/processor_idle.c
> 2004-12-23 14:24:13.328939202 +0100
> +++ linux-2.6.10-rc3+bk-acpi/drivers/acpi/processor_idle.c
> 2004-12-23 14:25:23.854099002 +0100
> @@ -834,7 +834,7 @@
> if (!pr)
> goto end;
>
> - seq_printf(seq, "active state: %d\n"
> + seq_printf(seq, "active state: C%d\n"
> "max_cstate: C%d\n"
> "bus master activity: %08x\n",
> pr->power.state ? pr->power.state -
> pr->power.states : 0,
> @@ -844,7 +844,7 @@
> seq_puts(seq, "states:\n");
>
> for (i = 1; i <= pr->power.count; i++) {
> - seq_printf(seq, " %c%d: ",
> + seq_printf(seq, " %cC%d: ",
> (&pr->power.states[i] == pr->power.state?'*':'
> '), i);
>
> if (!pr->power.states[i].valid) {
> @@ -868,18 +868,18 @@
> }
>
> if (pr->power.states[i].promotion.state)
> - seq_printf(seq, "promotion[%d] ",
> + seq_printf(seq, "promotion[C%d] ",
> (pr->power.states[i].promotion.state -
> pr->power.states));
> else
> - seq_puts(seq, "promotion[-] ");
> + seq_puts(seq, "promotion[--] ");
>
> if (pr->power.states[i].demotion.state)
> - seq_printf(seq, "demotion[%d] ",
> + seq_printf(seq, "demotion[C%d] ",
> (pr->power.states[i].demotion.state -
> pr->power.states));
> else
> - seq_puts(seq, "demotion[-] ");
> + seq_puts(seq, "demotion[--] ");
>
> seq_printf(seq, "latency[%03d] usage[%08d]\n",
> pr->power.states[i].latency,
> @@ -939,7 +939,7 @@
> printk(KERN_INFO PREFIX "CPU%d (power states:",
> pr->id);
> for (i = 1; i <= pr->power.count; i++)
> if (pr->power.states[i].valid)
> - printk(" %d[C%d]", i,
> pr->power.states[i].type);
> + printk(" C%d[C%d]", i,
> pr->power.states[i].type);
> printk(")\n");
>
> if (pr->id == 0) {
>
>
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-12-23 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-12-23 14:07 [PATCH 2/5] processor: C0, C1, C2 naming Dominik Brodowski
[not found] ` <20041223140723.GB7973-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org>
2004-12-23 20:09 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox