From: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Dominik Brodowski
<linux-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org>
Cc: ACPI Developers
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH 4/5] processor: nocst module parameter
Date: 23 Dec 2004 15:10:15 -0500 [thread overview]
Message-ID: <1103832613.4379.21.camel@d845pe> (raw)
In-Reply-To: <20041223140809.GD7973-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org>
Applied.
thanks,
-Len
On Thu, 2004-12-23 at 09:08, Dominik Brodowski wrote:
> Add a "nocst" module parameter which blocks _CST parsing and
> always uses FADT info instead.
>
> Signed-off-by: Dominik Brodowski <linux-JhLEnvuH02M@public.gmane.org>
> ---
>
> drivers/acpi/processor_idle.c | 13 ++++++++++---
> 1 files changed, 10 insertions(+), 3 deletions(-)
>
> Index: linux-2.6.10-rc3+bk-acpi/drivers/acpi/processor_idle.c
> ===================================================================
> --- linux-2.6.10-rc3+bk-acpi.orig/drivers/acpi/processor_idle.c
> 2004-12-23 14:25:28.737417644 +0100
> +++ linux-2.6.10-rc3+bk-acpi/drivers/acpi/processor_idle.c
> 2004-12-23 14:25:32.385908579 +0100
> @@ -55,7 +55,10 @@
> #define C3_OVERHEAD 4 /* 1us (3.579 ticks
> per us) */
>
> static void (*pm_idle_save)(void);
> -module_param_named(max_cstate, max_cstate, uint, 0644);
> +module_param(max_cstate, uint, 0644);
> +
> +static unsigned int nocst = 0;
> +module_param(nocst, uint, 0000);
>
> /*
> --------------------------------------------------------------------------
> Power Management
> @@ -506,6 +509,10 @@
>
> if (errata.smp)
> return_VALUE(-ENODEV);
> +
> + if (nocst)
> + return_VALUE(-ENODEV);
> +
> pr->power.count = 0;
> for (i = 0; i < ACPI_PROCESSOR_MAX_POWER; i++)
> memset(pr->power.states, 0, sizeof(struct
> acpi_processor_cx));
> @@ -800,7 +807,7 @@
> if (!pr)
> return_VALUE(-EINVAL);
>
> - if (errata.smp) {
> + if (errata.smp || nocst) {
> return_VALUE(-ENODEV);
> }
>
> @@ -917,7 +924,7 @@
> first_run++;
> }
>
> - if (!errata.smp && (pr->id == 0) && acpi_fadt.cst_cnt) {
> + if (!errata.smp && (pr->id == 0) && acpi_fadt.cst_cnt &&
> !nocst) {
> status = acpi_os_write_port(acpi_fadt.smi_cmd,
> acpi_fadt.cst_cnt, 8);
> if (ACPI_FAILURE(status)) {
> ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
>
>
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
prev parent reply other threads:[~2004-12-23 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-23 14:08 [PATCH 4/5] processor: nocst module parameter Dominik Brodowski
[not found] ` <20041223140809.GD7973-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org>
2004-12-23 20:10 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1103832613.4379.21.camel@d845pe \
--to=len.brown-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox