* [PATCH] ACPI: print PCI root names the same way the rest of the kernel does
@ 2005-02-18 23:15 Bjorn Helgaas
2005-03-09 5:22 ` [PATCH] ACPI: print PCI root names the same way the rest of thekernel does Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Helgaas @ 2005-02-18 23:15 UTC (permalink / raw)
To: Len Brown; +Cc: ACPI List
The rest of the kernel uses %04x:%02x for PCI domain:bus;
ACPI should do the same.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
===== drivers/acpi/pci_root.c 1.23 vs edited =====
--- 1.23/drivers/acpi/pci_root.c 2004-11-11 23:29:46 -07:00
+++ edited/drivers/acpi/pci_root.c 2005-02-15 14:10:14 -07:00
@@ -258,7 +258,7 @@
/* TBD: Locking */
list_add_tail(&root->node, &acpi_pci_roots);
- printk(KERN_INFO PREFIX "%s [%s] (%02x:%02x)\n",
+ printk(KERN_INFO PREFIX "%s [%s] (%04x:%02x)\n",
acpi_device_name(device), acpi_device_bid(device),
root->id.segment, root->id.bus);
@@ -272,7 +272,7 @@
root->bus = pci_acpi_scan_root(device, root->id.segment, root->id.bus);
if (!root->bus) {
ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
- "Bus %02x:%02x not present in PCI namespace\n",
+ "Bus %04x:%02x not present in PCI namespace\n",
root->id.segment, root->id.bus));
result = -ENODEV;
goto end;
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ACPI: print PCI root names the same way the rest of thekernel does
2005-02-18 23:15 [PATCH] ACPI: print PCI root names the same way the rest of the kernel does Bjorn Helgaas
@ 2005-03-09 5:22 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2005-03-09 5:22 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: ACPI List
Applied.
thanks,
-Len
On Fri, 2005-02-18 at 18:15, Bjorn Helgaas wrote:
> The rest of the kernel uses %04x:%02x for PCI domain:bus;
> ACPI should do the same.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
>
> ===== drivers/acpi/pci_root.c 1.23 vs edited =====
> --- 1.23/drivers/acpi/pci_root.c 2004-11-11 23:29:46 -07:00
> +++ edited/drivers/acpi/pci_root.c 2005-02-15 14:10:14 -07:00
> @@ -258,7 +258,7 @@
> /* TBD: Locking */
> list_add_tail(&root->node, &acpi_pci_roots);
>
> - printk(KERN_INFO PREFIX "%s [%s] (%02x:%02x)\n",
> + printk(KERN_INFO PREFIX "%s [%s] (%04x:%02x)\n",
> acpi_device_name(device), acpi_device_bid(device),
> root->id.segment, root->id.bus);
>
> @@ -272,7 +272,7 @@
> root->bus = pci_acpi_scan_root(device, root->id.segment,
> root->id.bus);
> if (!root->bus) {
> ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
> - "Bus %02x:%02x not present in PCI
> namespace\n",
> + "Bus %04x:%02x not present in PCI
> namespace\n",
> root->id.segment, root->id.bus));
> result = -ENODEV;
> goto end;
>
>
>
>
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-09 5:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-18 23:15 [PATCH] ACPI: print PCI root names the same way the rest of the kernel does Bjorn Helgaas
2005-03-09 5:22 ` [PATCH] ACPI: print PCI root names the same way the rest of thekernel does Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox