Re: Re: [patch 11/12] new sony_acpi driver

Timo Hoenig
2005-03-03T09:34:04Z

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

Hi,

On Thu, 2005-03-03 at 10:27 +0100, Stelian Pop wrote:
>Did you look at the code in those drivers ? There is no way you can
>delete them because each of them is very specific in the functionalities
>it offers and the way to achieve it.
>
>Sure, for basic stuff like the brightness you can hope to have a
>common code (like video.c today). It may even work on future laptops.
>But it won't work on older (todays) laptops (I'm not sure about the
>other brands, but it won't work on Sony Vaios). And even if when it
>works it won't do everything because vendors will always implement
>extensions.

Since the function implementations vary but their purpose is the same it
would be possible by creating generic wrapper functions (hotkey
implementation, trigger common hardware functions like fan,
bluetooth...). I'm not sure which way would be the best to cover laptop
specific functions which are not covered by the generic wrapper
functions.

[...]
>
>Stelian.

See you,

-- Timo

..............................................................
Timo Hönig <thoenig at nouse dot net>
..................................................:: gpg ::...
Fingerprint: 0998 0ACA A1D2 2612 4D96 DD8B E03F 084B B305 4066

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]