From: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
To: domen-CvScVCPLwOZg9hUCZPvPmw@public.gmane.org
Cc: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
ACPI List
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
hannal-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
janitor-Aga/KQc5HWxW3WIO4DnKWw@public.gmane.org
Subject: Re: [patch 1/1] arch/i386/pci/acpi.c Use for_each_pci_dev macro
Date: Mon, 07 Mar 2005 10:02:01 -0700 [thread overview]
Message-ID: <1110214921.21176.12.camel@eeyore> (raw)
In-Reply-To: <20050305152937.6C73F1EE1E-FMNAFCfKBdkof1z7V/zXpkB+6BGkLq7r@public.gmane.org>
On Sat, 2005-03-05 at 16:29 +0100, domen-CvScVCPLwOZg9hUCZPvPmw@public.gmane.org wrote:
> Using the new for_each_pci_dev macro. Compiled and boot tested.
>
> Signed-off-by: Hanna Linder <hannal-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Maximilian Attems <janitor-Aga/KQc5HWxW3WIO4DnKWw@public.gmane.org>
> Signed-off-by: Domen Puncer <domen-CvScVCPLwOZg9hUCZPvPmw@public.gmane.org>
> ---
>
>
> kj-domen/arch/i386/pci/acpi.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN arch/i386/pci/acpi.c~for-each-pci-dev-arch_i386_pci_acpi arch/i386/pci/acpi.c
> --- kj/arch/i386/pci/acpi.c~for-each-pci-dev-arch_i386_pci_acpi 2005-03-05 16:09:18.000000000 +0100
> +++ kj-domen/arch/i386/pci/acpi.c 2005-03-05 16:09:18.000000000 +0100
> @@ -41,7 +41,7 @@ static int __init pci_acpi_init(void)
> printk(KERN_INFO "** was specified. If this was required to make a driver work,\n");
> printk(KERN_INFO "** please email the output of \"lspci\" to bjorn.helgaas-VXdhtT5mjnY@public.gmane.org\n");
> printk(KERN_INFO "** so I can fix the driver.\n");
> - while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL)
> + for_each_pci_dev(dev)
> acpi_pci_irq_enable(dev);
> } else {
> printk(KERN_INFO "** PCI interrupts are no longer routed automatically. If this\n");
> _
>
>
This looks OK to me, but the patch will need to be updated because
Linus just applied my patch to change the printk message preceeding
your change.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
prev parent reply other threads:[~2005-03-07 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 15:29 [patch 1/1] arch/i386/pci/acpi.c Use for_each_pci_dev macro domen-CvScVCPLwOZg9hUCZPvPmw
[not found] ` <20050305152937.6C73F1EE1E-FMNAFCfKBdkof1z7V/zXpkB+6BGkLq7r@public.gmane.org>
2005-03-07 17:02 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110214921.21176.12.camel@eeyore \
--to=bjorn.helgaas-vxdhtt5mjny@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=domen-CvScVCPLwOZg9hUCZPvPmw@public.gmane.org \
--cc=hannal-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=janitor-Aga/KQc5HWxW3WIO4DnKWw@public.gmane.org \
--cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox