From: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
Cc: ACPI List <acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH] ACPI: print PCI root names the same way the rest of thekernel does
Date: 09 Mar 2005 00:22:01 -0500 [thread overview]
Message-ID: <1110345721.9337.15.camel@d845pe> (raw)
In-Reply-To: <1108768508.25491.44.camel@eeyore>
Applied.
thanks,
-Len
On Fri, 2005-02-18 at 18:15, Bjorn Helgaas wrote:
> The rest of the kernel uses %04x:%02x for PCI domain:bus;
> ACPI should do the same.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
>
> ===== drivers/acpi/pci_root.c 1.23 vs edited =====
> --- 1.23/drivers/acpi/pci_root.c 2004-11-11 23:29:46 -07:00
> +++ edited/drivers/acpi/pci_root.c 2005-02-15 14:10:14 -07:00
> @@ -258,7 +258,7 @@
> /* TBD: Locking */
> list_add_tail(&root->node, &acpi_pci_roots);
>
> - printk(KERN_INFO PREFIX "%s [%s] (%02x:%02x)\n",
> + printk(KERN_INFO PREFIX "%s [%s] (%04x:%02x)\n",
> acpi_device_name(device), acpi_device_bid(device),
> root->id.segment, root->id.bus);
>
> @@ -272,7 +272,7 @@
> root->bus = pci_acpi_scan_root(device, root->id.segment,
> root->id.bus);
> if (!root->bus) {
> ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
> - "Bus %02x:%02x not present in PCI
> namespace\n",
> + "Bus %04x:%02x not present in PCI
> namespace\n",
> root->id.segment, root->id.bus));
> result = -ENODEV;
> goto end;
>
>
>
>
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
prev parent reply other threads:[~2005-03-09 5:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-18 23:15 [PATCH] ACPI: print PCI root names the same way the rest of the kernel does Bjorn Helgaas
2005-03-09 5:22 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110345721.9337.15.camel@d845pe \
--to=len.brown-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=bjorn.helgaas-VXdhtT5mjnY@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox