Re: CONFIG_PM, CONFIG_ACPI, CONFIG_ACPI_SLEEP

[Sergio Monteiro Basto <sergio-qOf5bGQp09kptuEoxK/DLR2eb7JE58TQ@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

Hi, I had write about it on Apr/May 2004,

Because "Accidentally, I compile ACPI without CONFIG_PM on one Dell
something dual Pentium III and power off didn't work." 

For me this was a bug that has been introduced when ACPI enter in 2.4
because, before that, if I recall correctly  
"we couldn't compile ACPI without define CONFIG_PM"

Conclusion, to simplify, on kernel configuration, I propose to force
that (for compile ACPI we need define CONFIG_PM) (again?) with this
little patch on attach. 

thanks,

On Thu, 2005-03-10 at 09:15 +1100, Nigel Cunningham wrote:
> Hi.
> 
> On Thu, 2005-03-10 at 06:02, Len Brown wrote:
> > Today it is possible to build with
> > CONFIG_PM=n
> > CONFIG_ACPI=y
> > (however, CONFIG_ACPI_SLEEP does depend on CONFIG_PM)
> > 
> > Seems that the solution to the kexec poweroff issue
> > is simpler if ACPI can depend on CONFIG_PM being present:
> > http://bugzilla.kernel.org/show_bug.cgi?id=4041
> > 
> > Why shouldn't CONFIG_ACPI depend on CONFIG_PM
> > Why shouldn't CONFIG_ACPI_SLEEP simply be CONFIG_ACPI
> > 
> > I can't think of any good reasons not to simplify here, can you?
> 
> That sounds confusing to me. I thought that ACPI was much more than just
> power management. Doesn't it include IRQ routing, device enumeration and
> so on too?

yes, but we can say "ACPI without PM doesn't exist"

> 
> Regards,
> 
> Nigel
-- 
Sérgio M.B.

[-- Attachment #2: configopti-24.diff --]
[-- Type: text/x-patch, Size: 805 bytes --]

--- linux-2.4.26s/arch/i386/config.in.orig	2004-04-29 23:38:38.000000000 +0100
+++ linux-2.4.26s/arch/i386/config.in	2004-04-29 23:40:58.000000000 +0100
@@ -360,7 +360,7 @@
 bool 'Power Management support' CONFIG_PM
 
 dep_tristate '  Advanced Power Management BIOS support' CONFIG_APM $CONFIG_PM
-if [ "$CONFIG_APM" != "n" ]; then
+if [ "$CONFIG_APM" != "n" -a "$CONFIG_PM" = "y" ]; then
    bool '    Ignore USER SUSPEND' CONFIG_APM_IGNORE_USER_SUSPEND
    bool '    Enable PM at boot time' CONFIG_APM_DO_ENABLE
    bool '    Make CPU Idle calls when idle' CONFIG_APM_CPU_IDLE
@@ -370,7 +370,9 @@
    bool '    Use real mode APM BIOS call to power off' CONFIG_APM_REAL_MODE_POWER_OFF
 fi
 
-source drivers/acpi/Config.in
+if [ "$CONFIG_PM" = "y" ]; then
+	source drivers/acpi/Config.in
+fi
 
 endmenu