* [PATCH] PNPACPI: don't complain about vendor-defined resources
@ 2005-02-11 22:14 Bjorn Helgaas
2005-03-09 5:09 ` Len Brown
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2005-02-11 22:14 UTC (permalink / raw)
To: len.brown-ral2JQCrhuEAvxtiuMwx3w
Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
ambx1-IBH0VoN/3vPQT0dZR+AlfA, shaohua.li-ral2JQCrhuEAvxtiuMwx3w
Don't complain about vendor-defined resources, just ignore them.
And make warning messages a little more consistent.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
===== drivers/pnp/pnpacpi/rsparser.c 1.2 vs edited =====
--- 1.2/drivers/pnp/pnpacpi/rsparser.c 2004-10-31 18:21:10 -07:00
+++ edited/drivers/pnp/pnpacpi/rsparser.c 2005-02-11 12:43:12 -07:00
@@ -219,9 +219,10 @@
res->data.address64.min_address_range,
res->data.address64.address_length);
break;
+ case ACPI_RSTYPE_VENDOR:
+ break;
default:
- pnp_warn("PnPACPI: Alloc type : %d not handle",
- res->id);
+ pnp_warn("PnPACPI: unknown resource type %d", res->id);
return AE_ERROR;
}
@@ -508,7 +509,7 @@
case ACPI_RSTYPE_END_DPF:
return AE_CTRL_TERMINATE;
default:
- pnp_warn("PnPACPI:Option type: %d not handle", res->id);
+ pnp_warn("PnPACPI: unknown resource type %d", res->id);
return AE_ERROR;
}
@@ -810,7 +811,7 @@
mem ++;
break;
default: /* other type */
- pnp_warn("Invalid type");
+ pnp_warn("unknown resource type %d", resource->id);
return -EINVAL;
}
resource ++;
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] PNPACPI: don't complain about vendor-defined resources 2005-02-11 22:14 [PATCH] PNPACPI: don't complain about vendor-defined resources Bjorn Helgaas @ 2005-03-09 5:09 ` Len Brown 2005-03-12 0:07 ` Adam Belay 0 siblings, 1 reply; 6+ messages in thread From: Len Brown @ 2005-03-09 5:09 UTC (permalink / raw) To: Bjorn Helgaas; +Cc: ACPI Developers, Adam Belay, Shaohua Li Applied. thanks, -Len On Fri, 2005-02-11 at 17:14, Bjorn Helgaas wrote: > Don't complain about vendor-defined resources, just ignore them. > And make warning messages a little more consistent. > > Signed-off-by: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org> > > ===== drivers/pnp/pnpacpi/rsparser.c 1.2 vs edited ===== > --- 1.2/drivers/pnp/pnpacpi/rsparser.c 2004-10-31 18:21:10 -07:00 > +++ edited/drivers/pnp/pnpacpi/rsparser.c 2005-02-11 12:43:12 > -07:00 > @@ -219,9 +219,10 @@ > res->data.address64.min_address_range, > res->data.address64.address_length); > break; > + case ACPI_RSTYPE_VENDOR: > + break; > default: > - pnp_warn("PnPACPI: Alloc type : %d not handle", > - res->id); > + pnp_warn("PnPACPI: unknown resource type %d", > res->id); > return AE_ERROR; > } > > @@ -508,7 +509,7 @@ > case ACPI_RSTYPE_END_DPF: > return AE_CTRL_TERMINATE; > default: > - pnp_warn("PnPACPI:Option type: %d not handle", > res->id); > + pnp_warn("PnPACPI: unknown resource type %d", > res->id); > return AE_ERROR; > } > > @@ -810,7 +811,7 @@ > mem ++; > break; > default: /* other type */ > - pnp_warn("Invalid type"); > + pnp_warn("unknown resource type %d", > resource->id); > return -EINVAL; > } > resource ++; > > > > ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PNPACPI: don't complain about vendor-defined resources 2005-03-09 5:09 ` Len Brown @ 2005-03-12 0:07 ` Adam Belay [not found] ` <1110586059.12485.225.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Adam Belay @ 2005-03-12 0:07 UTC (permalink / raw) To: Len Brown; +Cc: Bjorn Helgaas, ACPI Developers, Shaohua Li On Wed, 2005-03-09 at 00:09 -0500, Len Brown wrote: > Applied. > > thanks, > -Len Just out of curiosity, are we seeing many vendor-defined resources from ACPI? Thanks, Adam ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1110586059.12485.225.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>]
* Re: [PATCH] PNPACPI: don't complain about vendor-defined resources [not found] ` <1110586059.12485.225.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> @ 2005-03-12 0:23 ` Bjorn Helgaas 2005-03-12 0:25 ` Adam Belay 0 siblings, 1 reply; 6+ messages in thread From: Bjorn Helgaas @ 2005-03-12 0:23 UTC (permalink / raw) To: Adam Belay; +Cc: Len Brown, ACPI Developers, Shaohua Li On Fri, 2005-03-11 at 19:07 -0500, Adam Belay wrote: > On Wed, 2005-03-09 at 00:09 -0500, Len Brown wrote: > > Applied. > > > > thanks, > > -Len > > Just out of curiosity, are we seeing many vendor-defined resources from > ACPI? HP boxes have some. Our host-to-AGP bridge, IOMMU, etc have them to tell you where the device's MMIO CSR space is. ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PNPACPI: don't complain about vendor-defined resources 2005-03-12 0:23 ` Bjorn Helgaas @ 2005-03-12 0:25 ` Adam Belay [not found] ` <1110587127.12485.236.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Adam Belay @ 2005-03-12 0:25 UTC (permalink / raw) To: Bjorn Helgaas; +Cc: Len Brown, ACPI Developers, Shaohua Li On Fri, 2005-03-11 at 17:23 -0700, Bjorn Helgaas wrote: > On Fri, 2005-03-11 at 19:07 -0500, Adam Belay wrote: > > On Wed, 2005-03-09 at 00:09 -0500, Len Brown wrote: > > > Applied. > > > > > > thanks, > > > -Len > > > > Just out of curiosity, are we seeing many vendor-defined resources from > > ACPI? > > HP boxes have some. Our host-to-AGP bridge, IOMMU, etc have them to > tell you where the device's MMIO CSR space is. Hmm, interesting. I'm asking because I was considering how necessary it would be to pass this information down to actual drivers. Thanks, Adam ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1110587127.12485.236.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>]
* Re: [PATCH] PNPACPI: don't complain about vendor-defined resources [not found] ` <1110587127.12485.236.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> @ 2005-03-12 16:54 ` Bjorn Helgaas 0 siblings, 0 replies; 6+ messages in thread From: Bjorn Helgaas @ 2005-03-12 16:54 UTC (permalink / raw) To: Adam Belay; +Cc: Len Brown, ACPI Developers, Shaohua Li On Fri, 2005-03-11 at 19:25 -0500, Adam Belay wrote: > On Fri, 2005-03-11 at 17:23 -0700, Bjorn Helgaas wrote: > > On Fri, 2005-03-11 at 19:07 -0500, Adam Belay wrote: > > > Just out of curiosity, are we seeing many vendor-defined resources from > > > ACPI? > > > > HP boxes have some. Our host-to-AGP bridge, IOMMU, etc have them to > > tell you where the device's MMIO CSR space is. > > Hmm, interesting. I'm asking because I was considering how necessary it > would be to pass this information down to actual drivers. See hp_acpi_csr_space(), used by the sba_iommu and hp-agp drivers. Which reminds me, I think the idea of using a UUID to label these vendor-defined resources made it into ACPI 3.0 (section 6.4.3.2). My plan was to move the infrastructure behind this (everything in arch/ia64/kernel/acpi-ext.c except the hp_ccsr_descriptor and hp_acpi_csr_space()) out of arch/ia64 and into drivers/acpi. Something else for my to-do list, I guess ;-) ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-03-12 16:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-11 22:14 [PATCH] PNPACPI: don't complain about vendor-defined resources Bjorn Helgaas
2005-03-09 5:09 ` Len Brown
2005-03-12 0:07 ` Adam Belay
[not found] ` <1110586059.12485.225.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2005-03-12 0:23 ` Bjorn Helgaas
2005-03-12 0:25 ` Adam Belay
[not found] ` <1110587127.12485.236.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2005-03-12 16:54 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox