Re: Re: Fw: Anybody? 2.6.11 (stable and -rc) ACPI breaks USB

Len Brown
2005-03-25T19:07:43Z

Applied.

thanks,
-Len

On Thu, 2005-03-24 at 13:24, Bjorn Helgaas wrote:
> On Wed, 2005-03-23 at 13:40 -0500, Len Brown wrote:
> > But checking skip_ioapic_setup in the non-ACPI case
> > isn't quite right. This is set for "noapic". But
> > it is not set in the PIC-mode case where the kernel
> > supports IOAPIC but the hardware does not -- in that
> > case the quirk would erroneously exit.
>
> Ah, right, thanks. I changed it to:
>
> if (nr_ioapics && !skip_ioapic_setup)
> return;
>
> Is that better?
>
> > Also, the original quirk_via_irqpic()
> > had a udelay(15) before the write -- I have no idea
> > if that was significant or not -- maybe soembody else
> > on the list does -- as none of us have VIA documentation...
>
> Yes, I was worried about that, too. I added it back.
>
> > ps. we need to fix this on 2.4 also.
>
> Here's yet another iteration for 2.6. If this works OK,
> I can back-port it to 2.4.
...