From: Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Patch: enable runtime GPEs before calling _WAK method
Date: Sun, 27 Mar 2005 00:34:15 +0000 [thread overview]
Message-ID: <1111883655.11677.59.camel@tyrosine> (raw)
The following patch enables runtime GPEs before calling _WAK. This
appears to be needed for resume from disk to work properly on an HP 6220
- without it, if the fan state has changed between suspend and resume,
kacpid consumes 100% of the CPU time and the fan speed remains constant.
>From playing with this, I assume that it's because the _WAK method
triggers an event that isn't handled because the GPEs haven't been
enabled.
diff -ur build-386/drivers/acpi/hardware/hwsleep.c build-686/drivers/acpi/hardware/hwsleep.c
--- build-386/drivers/acpi/hardware/hwsleep.c 2005-03-17 20:40:58.000000000 +0000
+++ build-686/drivers/acpi/hardware/hwsleep.c 2005-03-26 23:48:29.000000000 +0000
@@ -543,12 +543,6 @@
ACPI_REPORT_ERROR (("Method _BFS failed, %s\n", acpi_format_exception (status)));
}
- status = acpi_evaluate_object (NULL, METHOD_NAME__WAK, &arg_list, NULL);
- if (ACPI_FAILURE (status) && status != AE_NOT_FOUND) {
- ACPI_REPORT_ERROR (("Method _WAK failed, %s\n", acpi_format_exception (status)));
- }
- /* TBD: _WAK "sometimes" returns stuff - do we want to look at it? */
-
/*
* Restore the GPEs:
* 1) Disable/Clear all GPEs
@@ -565,6 +559,12 @@
return_ACPI_STATUS (status);
}
+ status = acpi_evaluate_object (NULL, METHOD_NAME__WAK, &arg_list, NULL);
+ if (ACPI_FAILURE (status) && status != AE_NOT_FOUND) {
+ ACPI_REPORT_ERROR (("Method _WAK failed, %s\n", acpi_format_exception (status)));
+ }
+ /* TBD: _WAK "sometimes" returns stuff - do we want to look at it? */
+
/* Enable power button */
(void) acpi_set_register(acpi_gbl_fixed_event_info[ACPI_EVENT_POWER_BUTTON].enable_register_id,
--
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
next reply other threads:[~2005-03-27 0:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-27 0:34 Matthew Garrett [this message]
2005-03-30 6:58 ` Patch: enable runtime GPEs before calling _WAK method Yu, Luming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1111883655.11677.59.camel@tyrosine \
--to=mjg59-1xo5oi07kqx4cg9nei1l7q@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox