public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
	Luming Yu <luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: ACPI Developers
	<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [patch 4/4] acpi: create_polling_proc() fix
Date: 30 Mar 2005 22:56:47 -0500	[thread overview]
Message-ID: <1112241407.2173.72.camel@d845pe> (raw)
In-Reply-To: <200503302116.j2ULGeuq027736-bipKiLWnuIsyyg0EjBt7GtHuzzzSOjJt@public.gmane.org>

Applied.

thanks,
-Len

On Wed, 2005-03-30 at 16:16, akpm-3NddpPZAyC0@public.gmane.org wrote:
> 
> drivers/acpi/hotkey.c: In function `create_polling_proc':
> drivers/acpi/hotkey.c:334: warning: ISO C90 forbids mixed declarations
> and code
> 
> 
> Signed-off-by: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>
> ---
> 
>  25-akpm/drivers/acpi/hotkey.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff -puN drivers/acpi/hotkey.c~acpi-create_polling_proc-fix
> drivers/acpi/hotkey.c
> --- 25/drivers/acpi/hotkey.c~acpi-create_polling_proc-fix       Wed
> Mar 30 13:16:09 2005
> +++ 25-akpm/drivers/acpi/hotkey.c       Wed Mar 30 13:16:09 2005
> @@ -329,9 +329,10 @@ static int auto_hotkey_remove(struct acp
>  static int create_polling_proc(union acpi_hotkey *device)
>  {
>         struct proc_dir_entry *proc;
> +       mode_t mode;
> 
>         ACPI_FUNCTION_TRACE("create_polling_proc");
> -       mode_t mode = S_IFREG | S_IRUGO | S_IWUGO;
> +       mode = S_IFREG | S_IRUGO | S_IWUGO;
> 
>         proc = create_proc_entry(device->poll_hotkey.action_method,
>                                  mode, hotkey_proc_dir);
> _
> 
> 



-------------------------------------------------------
This SF.net email is sponsored by Demarc:
A global provider of Threat Management Solutions.
Download our HomeAdmin security software for free today!
http://www.demarc.com/Info/Sentarus/hamr30

      parent reply	other threads:[~2005-03-31  3:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-30 21:16 [patch 4/4] acpi: create_polling_proc() fix akpm-3NddpPZAyC0
     [not found] ` <200503302116.j2ULGeuq027736-bipKiLWnuIsyyg0EjBt7GtHuzzzSOjJt@public.gmane.org>
2005-03-31  3:56   ` Len Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1112241407.2173.72.camel@d845pe \
    --to=len.brown-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=akpm-3NddpPZAyC0@public.gmane.org \
    --cc=luming.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox