* [patch 4/4] acpi: create_polling_proc() fix
@ 2005-03-30 21:16 akpm-3NddpPZAyC0
[not found] ` <200503302116.j2ULGeuq027736-bipKiLWnuIsyyg0EjBt7GtHuzzzSOjJt@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: akpm-3NddpPZAyC0 @ 2005-03-30 21:16 UTC (permalink / raw)
To: len.brown-ral2JQCrhuEAvxtiuMwx3w
Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f, akpm-3NddpPZAyC0
drivers/acpi/hotkey.c: In function `create_polling_proc':
drivers/acpi/hotkey.c:334: warning: ISO C90 forbids mixed declarations and code
Signed-off-by: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>
---
25-akpm/drivers/acpi/hotkey.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
diff -puN drivers/acpi/hotkey.c~acpi-create_polling_proc-fix drivers/acpi/hotkey.c
--- 25/drivers/acpi/hotkey.c~acpi-create_polling_proc-fix Wed Mar 30 13:16:09 2005
+++ 25-akpm/drivers/acpi/hotkey.c Wed Mar 30 13:16:09 2005
@@ -329,9 +329,10 @@ static int auto_hotkey_remove(struct acp
static int create_polling_proc(union acpi_hotkey *device)
{
struct proc_dir_entry *proc;
+ mode_t mode;
ACPI_FUNCTION_TRACE("create_polling_proc");
- mode_t mode = S_IFREG | S_IRUGO | S_IWUGO;
+ mode = S_IFREG | S_IRUGO | S_IWUGO;
proc = create_proc_entry(device->poll_hotkey.action_method,
mode, hotkey_proc_dir);
_
-------------------------------------------------------
This SF.net email is sponsored by Demarc:
A global provider of Threat Management Solutions.
Download our HomeAdmin security software for free today!
http://www.demarc.com/Info/Sentarus/hamr30
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 4/4] acpi: create_polling_proc() fix
[not found] ` <200503302116.j2ULGeuq027736-bipKiLWnuIsyyg0EjBt7GtHuzzzSOjJt@public.gmane.org>
@ 2005-03-31 3:56 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2005-03-31 3:56 UTC (permalink / raw)
To: Andrew Morton, Luming Yu; +Cc: ACPI Developers
Applied.
thanks,
-Len
On Wed, 2005-03-30 at 16:16, akpm-3NddpPZAyC0@public.gmane.org wrote:
>
> drivers/acpi/hotkey.c: In function `create_polling_proc':
> drivers/acpi/hotkey.c:334: warning: ISO C90 forbids mixed declarations
> and code
>
>
> Signed-off-by: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>
> ---
>
> 25-akpm/drivers/acpi/hotkey.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletion(-)
>
> diff -puN drivers/acpi/hotkey.c~acpi-create_polling_proc-fix
> drivers/acpi/hotkey.c
> --- 25/drivers/acpi/hotkey.c~acpi-create_polling_proc-fix Wed
> Mar 30 13:16:09 2005
> +++ 25-akpm/drivers/acpi/hotkey.c Wed Mar 30 13:16:09 2005
> @@ -329,9 +329,10 @@ static int auto_hotkey_remove(struct acp
> static int create_polling_proc(union acpi_hotkey *device)
> {
> struct proc_dir_entry *proc;
> + mode_t mode;
>
> ACPI_FUNCTION_TRACE("create_polling_proc");
> - mode_t mode = S_IFREG | S_IRUGO | S_IWUGO;
> + mode = S_IFREG | S_IRUGO | S_IWUGO;
>
> proc = create_proc_entry(device->poll_hotkey.action_method,
> mode, hotkey_proc_dir);
> _
>
>
-------------------------------------------------------
This SF.net email is sponsored by Demarc:
A global provider of Threat Management Solutions.
Download our HomeAdmin security software for free today!
http://www.demarc.com/Info/Sentarus/hamr30
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-31 3:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-30 21:16 [patch 4/4] acpi: create_polling_proc() fix akpm-3NddpPZAyC0
[not found] ` <200503302116.j2ULGeuq027736-bipKiLWnuIsyyg0EjBt7GtHuzzzSOjJt@public.gmane.org>
2005-03-31 3:56 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox