[RFC/PATCH 1/3] ACPI based I/O APIC hot-plug

[RFC/PATCH 1/3] ACPI based I/O APIC hot-plug

[Kenji Kaneshige]

This patch adds the following new interfaces for I/O xAPIC
hotplug. The implementation of these interfaces depends on each
architecture.

    o int acpi_register_ioapic(acpi_handle handle, u64 phys_addr,
			       u32 gsi_base);

        This new interface is to add a new I/O xAPIC specified by
        phys_addr and gsi_base pair. phys_addr is the physical address
        to which the I/O xAPIC is mapped and gsi_base is global system
        interrupt base of the I/O xAPIC. acpi_register_ioapic returns
        0 on success, or negative value on error.

    o int acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base);

        This new interface is to remove a I/O xAPIC specified by
        gsi_base. acpi_unregister_ioapic returns 0 on success, or
        negative value on error.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji-+CUm20s59erQFUHtdCDX3A@public.gmane.org>


---

 linux-2.6.12-rc2-mm3-kanesige/arch/i386/kernel/acpi/boot.c |   16 ++++++++++++
 linux-2.6.12-rc2-mm3-kanesige/arch/ia64/kernel/acpi.c      |   17 +++++++++++++
 linux-2.6.12-rc2-mm3-kanesige/include/linux/acpi.h         |    3 ++
 3 files changed, 36 insertions(+)

diff -puN arch/i386/kernel/acpi/boot.c~ioapic_hotplug_acpi arch/i386/kernel/acpi/boot.c
--- linux-2.6.12-rc2-mm3/arch/i386/kernel/acpi/boot.c~ioapic_hotplug_acpi	2005-04-20 10:51:30.128486652 +0900
+++ linux-2.6.12-rc2-mm3-kanesige/arch/i386/kernel/acpi/boot.c	2005-04-20 10:51:45.876533334 +0900
@@ -506,6 +506,22 @@ acpi_unmap_lsapic(int cpu)
 EXPORT_SYMBOL(acpi_unmap_lsapic);
 #endif /* CONFIG_ACPI_HOTPLUG_CPU */
 
+int
+acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base)
+{
+	/* TBD */
+	return -EINVAL;
+}
+EXPORT_SYMBOL(acpi_register_ioapic);
+
+int
+acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base)
+{
+	/* TBD */
+	return -EINVAL;
+}
+EXPORT_SYMBOL(acpi_unregister_ioapic);
+
 static unsigned long __init
 acpi_scan_rsdp (
 	unsigned long		start,
diff -puN arch/ia64/kernel/acpi.c~ioapic_hotplug_acpi arch/ia64/kernel/acpi.c
--- linux-2.6.12-rc2-mm3/arch/ia64/kernel/acpi.c~ioapic_hotplug_acpi	2005-04-20 10:51:30.131416339 +0900
+++ linux-2.6.12-rc2-mm3-kanesige/arch/ia64/kernel/acpi.c	2005-04-20 10:51:30.136299152 +0900
@@ -892,4 +892,21 @@ acpi_map_iosapic (acpi_handle handle, u3
 	return AE_OK;
 }
 #endif /* CONFIG_NUMA */
+
+int
+acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base)
+{
+	/* TBD */
+	return -EINVAL;
+}
+EXPORT_SYMBOL(acpi_register_ioapic);
+
+int
+acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base)
+{
+	/* TBD */
+	return -EINVAL;
+}
+EXPORT_SYMBOL(acpi_unregister_ioapic);
+
 #endif /* CONFIG_ACPI_BOOT */
diff -puN include/linux/acpi.h~ioapic_hotplug_acpi include/linux/acpi.h
--- linux-2.6.12-rc2-mm3/include/linux/acpi.h~ioapic_hotplug_acpi	2005-04-20 10:51:30.133369464 +0900
+++ linux-2.6.12-rc2-mm3-kanesige/include/linux/acpi.h	2005-04-20 10:51:30.137275714 +0900
@@ -408,6 +408,9 @@ int acpi_map_lsapic(acpi_handle handle, 
 int acpi_unmap_lsapic(int cpu);
 #endif /* CONFIG_ACPI_HOTPLUG_CPU */
 
+int acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base);
+int acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base);
+
 extern int acpi_mp_config;
 
 extern u32 pci_mmcfg_base_addr;

_


-------------------------------------------------------
This SF.Net email is sponsored by: New Crystal Reports XI.
Version 11 adds new functionality designed to reduce time involved in
creating, integrating, and deploying reporting solutions. Free runtime info,
new features, or free trial, at: http://www.businessobjects.com/devxi/728

Re: [ACPI] [RFC/PATCH 1/3] ACPI based I/O APIC hot-plug

[Bjorn Helgaas]

> +++ linux-2.6.12-rc2-mm3-kanesige/arch/ia64/kernel/acpi.c	2005-04-20 10:51:30.136299152 +0900
> @@ -892,4 +892,21 @@ acpi_map_iosapic (acpi_handle handle, u3
>  	return AE_OK;
>  }
>  #endif /* CONFIG_NUMA */
> +
> +int
> +acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base)
> +{
> +	/* TBD */
> +	return -EINVAL;
> +}
> +EXPORT_SYMBOL(acpi_register_ioapic);
> +
> +int
> +acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base)

Nitpick: these declarations should follow the style of the rest
of the file, i.e., add a space between the function name and the
opening parenthesis.

Re: [ACPI] [RFC/PATCH 1/3] ACPI based I/O APIC hot-plug

[Kenji Kaneshige]

Hi Bjorn,

Thank you very much for comments.
I'll update my patches based on your comments.

Regards,
Kenji Kaneshige


Bjorn Helgaas wrote:
>>+++ linux-2.6.12-rc2-mm3-kanesige/arch/ia64/kernel/acpi.c	2005-04-20 10:51:30.136299152 +0900
>>@@ -892,4 +892,21 @@ acpi_map_iosapic (acpi_handle handle, u3
>> 	return AE_OK;
>> }
>> #endif /* CONFIG_NUMA */
>>+
>>+int
>>+acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base)
>>+{
>>+	/* TBD */
>>+	return -EINVAL;
>>+}
>>+EXPORT_SYMBOL(acpi_register_ioapic);
>>+
>>+int
>>+acpi_unregister_ioapic(acpi_handle handle, u32 gsi_base)
> 
> 
> Nitpick: these declarations should follow the style of the rest
> of the file, i.e., add a space between the function name and the
> opening parenthesis.
> 
> 

Re: [Pcihpd-discuss] Re: [ACPI] [RFC/PATCH 1/3] ACPI based I/O APIC hot-plug

[Rolf Eike Beer]

Am Freitag, 22. April 2005 08:38 schrieb Kenji Kaneshige:
> Hi Bjorn,

> > Nitpick: these declarations should follow the style of the rest
> > of the file, i.e., add a space between the function name and the
> > opening parenthesis.
>
> Thank you very much for comments.
> I'll update my patches based on your comments.

No, please don't do this. It just causes me to send another patch to kill them 
alltogether.

Eike

Re: [Pcihpd-discuss] Re: [RFC/PATCH 1/3] ACPI based I/O APIC hot-plug

[Bjorn Helgaas]

On Fri, 2005-04-22 at 09:53 +0200, Rolf Eike Beer wrote:
> Am Freitag, 22. April 2005 08:38 schrieb Kenji Kaneshige:
> > Hi Bjorn,
> 
> > > Nitpick: these declarations should follow the style of the rest
> > > of the file, i.e., add a space between the function name and the
> > > opening parenthesis.
> >
> > Thank you very much for comments.
> > I'll update my patches based on your comments.
> 
> No, please don't do this. It just causes me to send another patch to kill them 
> alltogether.

Don't be silly.  If you want to change the whole file to conform to
one style, fine.  I even agree with the sentiment that arch/ia64
would be better off if it were more consistent with the rest of the
kernel.

But isolated changes to a file should follow the style of the rest
of the file.



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click