From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [Pcihpd-discuss] Re: [RFC/PATCH 1/3] ACPI based I/O APIC hot-plug Date: Fri, 22 Apr 2005 08:56:19 -0600 Message-ID: <1114181779.4902.1.camel@eeyore> References: <4267AD13.5080900@jp.fujitsu.com> <1114104091.2784.40.camel@eeyore> <42689BE6.4040004@jp.fujitsu.com> <200504220953.20831@bilbo.math.uni-mannheim.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200504220953.20831-rMKJyNB0tZ8LKYO4ye7UPbyZi+5vbtHrhC4ANOJQIlc@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Rolf Eike Beer Cc: pcihpd-discuss-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Kenji Kaneshige , Andrew Morton , Len Brown , "Luck, Tony" , Greg KH , acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-acpi@vger.kernel.org On Fri, 2005-04-22 at 09:53 +0200, Rolf Eike Beer wrote: > Am Freitag, 22. April 2005 08:38 schrieb Kenji Kaneshige: > > Hi Bjorn, > > > > Nitpick: these declarations should follow the style of the rest > > > of the file, i.e., add a space between the function name and the > > > opening parenthesis. > > > > Thank you very much for comments. > > I'll update my patches based on your comments. > > No, please don't do this. It just causes me to send another patch to kill them > alltogether. Don't be silly. If you want to change the whole file to conform to one style, fine. I even agree with the sentiment that arch/ia64 would be better off if it were more consistent with the rest of the kernel. But isolated changes to a file should follow the style of the rest of the file. ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click