Re: [PATCH 1/2] IPMI and acpi=off|ht : acpi-get-firmware-failure.patch

[Sergio Monteiro Basto <sergio-qOf5bGQp09kptuEoxK/DLR2eb7JE58TQ@public.gmane.org>]

Hi,
I am CCing to Robert Moore because is about acpi/tables/tbxfroot.c. This
is code from ACPICA
http://developer.intel.com/technology/iapc/acpi/downloads.htm
So we have to wait for the next version of ACPICA, on dmesg we can find
it, for example:  

ACPI: Subsystem revision 20050211

thanks,

On Mon, 2005-05-16 at 23:42 +0200, Yann Droneaud wrote:
> This patch check that rsdt_info->pointer is not NULL before trying to
> unmap ACPI tables, which can happen if acpi_tb_get_rsdt_address() failed.
> 
> In my case, with ipmi_si_intf module and acpi=ht|off parameter, the call
> failed because acpi_gbl_table_flags is not initialised, so the
> address.pointer_type is not setup correctly, leading to message like:
> 
> May 16 11:18:29 localhost kernel:     ACPI-0166: *** Error: Invalid address flags 8
> 
> and rsdt_info->pointer equal to NULL leading to the Oops.
> 
> --- linux-2.6.11.9/drivers/acpi/tables/tbxfroot.c	2005-05-11 18:42:39.000000000 -0400
> +++ linux-2.6.11.9-fixes/drivers/acpi/tables/tbxfroot.c	2005-05-16 16:51:33.115768232 -0400
> @@ -313,7 +313,9 @@ acpi_get_firmware_table (
>  
> 
>  cleanup:
> -	acpi_os_unmap_memory (rsdt_info->pointer, (acpi_size) rsdt_info->pointer->length);
> +	if (rsdt_info->pointer) {
> +		acpi_os_unmap_memory (rsdt_info->pointer, (acpi_size) rsdt_info->pointer->length);
> +	}
>  	ACPI_MEM_FREE (rsdt_info);
>  
>  	if (header) {
> 
> 
> Signed-Off-by: ydroneaud-4qZELD6FgxhWk0Htik3J/w@public.gmane.org
> 
-- 
Sérgio M.B.



-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7412&alloc_id=16344&op=click