From: Alexander Nyberg <alexn@telia.com>
To: Len Brown <lenb@toshiba.hsd1.ma.comcast.net>
Cc: acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
torvalds@osdl.org, bjorn.helgaas@hp.com
Subject: Re: [PATCH] VIA IRQ quirk for 2.6.12-rc5
Date: Fri, 27 May 2005 12:27:05 +0200 [thread overview]
Message-ID: <1117189625.949.9.camel@localhost.localdomain> (raw)
In-Reply-To: <20050527082150.GA24428@toshiba.hsd1.ma.comcast.net>
> Linus,
> Please apply this patch to 2.6.12-rc5.
> It fixes a 2.6.11 regression in the VIA IRQ quirk
> on machines with mixed vendor chip-sets.
>
> thanks,
> Len
>
>
> Delete quirk_via_bridge(), restore quirk_via_irqpic() --
> but now improved to be invoked upon device ENABLE, and
> now only for VIA devices -- not all devices behind VIA bridges.
Please drop the __devinit on quirk_via_irqpic() or apply the patch I'm
putting at the bottom. Also there seems to be a completely unrelated
acpi chunk at the bottom of your patch...
quirk_via_irqpic can't be __devinit for swsuspend
Signed-off-by: Alexander Nyberg <alexn@telia.com>
Index: linux-2.6/drivers/pci/quirks.c
===================================================================
--- linux-2.6.orig/drivers/pci/quirks.c 2005-05-27 12:15:17.000000000 +0200
+++ linux-2.6/drivers/pci/quirks.c 2005-05-27 12:17:10.000000000 +0200
@@ -492,7 +492,7 @@
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_3, quirk_via_acpi );
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4, quirk_via_acpi );
-static void __devinit quirk_via_irqpic(struct pci_dev *dev)
+static void quirk_via_irqpic(struct pci_dev *dev)
{
u8 irq, new_irq;
next prev parent reply other threads:[~2005-05-27 10:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 8:21 [PATCH] VIA IRQ quirk for 2.6.12-rc5 Len Brown
2005-05-27 8:53 ` [PATCH] ACPI build fix " Len Brown
2005-05-27 10:48 ` Alexander Nyberg
[not found] ` <20050527085326.GA29767-g3qfMnKXm6l/wjb6y0L7XlrsPObopucw0e7PPNI6Mm0@public.gmane.org>
2005-05-27 15:27 ` Linus Torvalds
2005-05-27 10:27 ` Alexander Nyberg [this message]
[not found] ` <20050527082150.GA24428-g3qfMnKXm6l/wjb6y0L7XlrsPObopucw0e7PPNI6Mm0@public.gmane.org>
2005-05-27 10:09 ` [PATCH] VIA IRQ quirk " Alan Cox
[not found] ` <1117188546.5730.175.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2005-06-22 16:17 ` Bjorn Helgaas
2005-05-27 15:47 ` Sergio Monteiro Basto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117189625.949.9.camel@localhost.localdomain \
--to=alexn@telia.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=bjorn.helgaas@hp.com \
--cc=lenb@toshiba.hsd1.ma.comcast.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox