public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Nyberg <alexn-zq6IREYz3ykAvxtiuMwx3w@public.gmane.org>
To: Linus Torvalds <torvalds-3NddpPZAyC0@public.gmane.org>
Cc: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	Norbert Federa
	<norbert.federa-uHwDyaZCXy1BDgjK7y7TUQ@public.gmane.org>,
	Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: Re: Changeset "acpi: disable PCI links at boot again, fix ELCR" -> on-board nic adapter not working
Date: Sat, 02 Jul 2005 12:34:58 +0200	[thread overview]
Message-ID: <1120300498.1171.3.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.58.0506241143520.11175-gWtpgVMusWVb5UGfqNBoRg@public.gmane.org>

> > My preference is to use acpi_register_gsi() rather than
> > calling eisa_set_level_irq() directly.
> 
> Ok. Norbert, just because I'm anal, can you verify that that version also
> fixes it before I commit it?

It appears this change:

diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
--- a/drivers/acpi/pci_irq.c
+++ b/drivers/acpi/pci_irq.c
@@ -435,6 +435,7 @@ acpi_pci_irq_enable (
                /* Interrupt Line values above 0xF are forbidden */
                if (dev->irq >= 0 && (dev->irq <= 0xF)) {
                        printk(" - using IRQ %d\n", dev->irq);
+                       acpi_register_gsi(dev->irq, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
                        return_VALUE(0);
                }
                else {


Caused some problems reported at:
http://bugme.osdl.org/show_bug.cgi?id=4824

Will the acpi guys reassign this bug to them?



-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click

  parent reply	other threads:[~2005-07-02 10:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <42B7CF33.5090501@neoware.com>
     [not found] ` <Pine.LNX.4.58.0506210901230.2268@ppc970.osdl.org>
     [not found]   ` <42B843F6.7040704@neoware.com>
     [not found]     ` <42B843F6.7040704-uHwDyaZCXy1BDgjK7y7TUQ@public.gmane.org>
2005-06-22 20:02       ` Changeset "acpi: disable PCI links at boot again, fix ELCR" -> on-board nic adapter not working Linus Torvalds
     [not found]         ` <Pine.LNX.4.58.0506221245370.2353-gWtpgVMusWVb5UGfqNBoRg@public.gmane.org>
2005-06-22 20:14           ` Linus Torvalds
2005-06-23  7:35           ` Norbert Federa
     [not found]             ` <42BA6639.9090402-uHwDyaZCXy1BDgjK7y7TUQ@public.gmane.org>
2005-06-24 18:01               ` Linus Torvalds
     [not found]                 ` <Pine.LNX.4.58.0506241100290.11175-gWtpgVMusWVb5UGfqNBoRg@public.gmane.org>
2005-06-24 18:31                   ` Bjorn Helgaas
     [not found]                     ` <200506241231.55760.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
2005-06-24 18:44                       ` Linus Torvalds
     [not found]                         ` <Pine.LNX.4.58.0506241143520.11175-gWtpgVMusWVb5UGfqNBoRg@public.gmane.org>
2005-06-25 10:43                           ` Norbert Federa
2005-07-02 10:34                           ` Alexander Nyberg [this message]
     [not found]                             ` <1120300498.1171.3.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2005-07-02 17:33                               ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1120300498.1171.3.camel@localhost.localdomain \
    --to=alexn-zq6ireyz3ykavxtiumwx3w@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=bjorn.helgaas-VXdhtT5mjnY@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=norbert.federa-uHwDyaZCXy1BDgjK7y7TUQ@public.gmane.org \
    --cc=torvalds-3NddpPZAyC0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox