From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Nyberg Subject: Re: Re: Changeset "acpi: disable PCI links at boot again, fix ELCR" -> on-board nic adapter not working Date: Sat, 02 Jul 2005 12:34:58 +0200 Message-ID: <1120300498.1171.3.camel@localhost.localdomain> References: <42B7CF33.5090501@neoware.com> <42BA6639.9090402@neoware.com> <200506241231.55760.bjorn.helgaas@hp.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Linus Torvalds Cc: Bjorn Helgaas , acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Norbert Federa , Len Brown List-Id: linux-acpi@vger.kernel.org > > My preference is to use acpi_register_gsi() rather than > > calling eisa_set_level_irq() directly. > > Ok. Norbert, just because I'm anal, can you verify that that version also > fixes it before I commit it? It appears this change: diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c --- a/drivers/acpi/pci_irq.c +++ b/drivers/acpi/pci_irq.c @@ -435,6 +435,7 @@ acpi_pci_irq_enable ( /* Interrupt Line values above 0xF are forbidden */ if (dev->irq >= 0 && (dev->irq <= 0xF)) { printk(" - using IRQ %d\n", dev->irq); + acpi_register_gsi(dev->irq, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW); return_VALUE(0); } else { Caused some problems reported at: http://bugme.osdl.org/show_bug.cgi?id=4824 Will the acpi guys reassign this bug to them? ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click