Re: [PATCH]Disable ACPI PCI link device if no PCI device uses it - takes 2

Greg KH
2005-07-28T05:25:08Z

On Tue, Jul 26, 2005 at 03:52:23PM +0800, Shaohua Li wrote:
> Hi,
> Looks like people agree device drivers should call
> free_irq/pci_disable_irq at suspend time per the OLS report. This patch
> tries to disable pci link device if no PCI device is using it, which is
> one goal of pci driver calls pci_disable_irq. This patch also warns
> users if some drivers don't call pci_disable_irq at suspend time. Next
> step we will implement acpi_unregister_gsi for x86/x86_64, so we can
> automically mask ioapic/pic if no device is using them. And in the same
> way, alarm users if driver doesn't call free_irq at suspend time.
> Greg, is the PCI part ok for you? It just has very small changes in PCI
> part.

Looks ok to me.

thanks,

greg k-h

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September
19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf