public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Shaohua Li <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
Cc: Matthieu Castet <castet.matthieu-GANU6spQydw@public.gmane.org>,
	Adam Belay <ambx1-IBH0VoN/3vPQT0dZR+AlfA@public.gmane.org>,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	Tony Luck <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] PNPACPI: handle address descriptors in _PRS
Date: Wed, 21 Sep 2005 09:17:32 +0800	[thread overview]
Message-ID: <1127265452.4040.3.camel@linux-hp.sh.intel.com> (raw)
In-Reply-To: <200509201626.15973.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>

Hi,
On Tue, 2005-09-20 at 16:26 -0600, Bjorn Helgaas wrote:
> PNPACPI complained about and ignored devices with ADDRESS16, ADDRESS32,
> or ADDRESS64 descriptors in _PRS.  Those descriptors seem legitimate,
> and HP firmware uses them for built-in serial ports, so this patch adds
> support for them.
> 
> But I notice the mention of them under "#if 0" -- did somebody explicitly
> decide not to handle them?  If so, what was the reason?
IIRC, the reason is just we did find any pnp device uses it. If hp
firmware uses it, we should add the support.
You might have missed the similar change in pnpacpi_encode_resources in
your patch. It's used when we assign new resources (_SRS method) to pnp
devices.

Thanks,
Shaohua



-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. 
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php

  parent reply	other threads:[~2005-09-21  1:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-20 22:26 [PATCH] PNPACPI: handle address descriptors in _PRS Bjorn Helgaas
     [not found] ` <200509201626.15973.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
2005-09-21  1:17   ` Shaohua Li [this message]
     [not found]     ` <1127265452.4040.3.camel-ECwVeV2eNyQD0+JXs3kMbRL4W9x8LtSr@public.gmane.org>
2005-09-21 15:27       ` Bjorn Helgaas
     [not found]         ` <200509210927.03377.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
2005-09-22  0:49           ` Shaohua Li
     [not found]             ` <1127350144.3961.5.camel-ECwVeV2eNyQD0+JXs3kMbRL4W9x8LtSr@public.gmane.org>
2005-09-22 23:48               ` Bjorn Helgaas
     [not found]                 ` <200509221748.30090.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
2005-09-23  0:55                   ` Shaohua Li
  -- strict thread matches above, loose matches on Subject: below --
2005-09-23 16:06 Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1127265452.4040.3.camel@linux-hp.sh.intel.com \
    --to=shaohua.li-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=ambx1-IBH0VoN/3vPQT0dZR+AlfA@public.gmane.org \
    --cc=bjorn.helgaas-VXdhtT5mjnY@public.gmane.org \
    --cc=castet.matthieu-GANU6spQydw@public.gmane.org \
    --cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox