From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shaohua Li Subject: Re: [PATCH] PNPACPI: handle address descriptors in _PRS Date: Wed, 21 Sep 2005 09:17:32 +0800 Message-ID: <1127265452.4040.3.camel@linux-hp.sh.intel.com> References: <200509201626.15973.bjorn.helgaas@hp.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200509201626.15973.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Bjorn Helgaas Cc: Matthieu Castet , Adam Belay , acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Tony Luck List-Id: linux-acpi@vger.kernel.org Hi, On Tue, 2005-09-20 at 16:26 -0600, Bjorn Helgaas wrote: > PNPACPI complained about and ignored devices with ADDRESS16, ADDRESS32, > or ADDRESS64 descriptors in _PRS. Those descriptors seem legitimate, > and HP firmware uses them for built-in serial ports, so this patch adds > support for them. > > But I notice the mention of them under "#if 0" -- did somebody explicitly > decide not to handle them? If so, what was the reason? IIRC, the reason is just we did find any pnp device uses it. If hp firmware uses it, we should add the support. You might have missed the similar change in pnpacpi_encode_resources in your patch. It's used when we assign new resources (_SRS method) to pnp devices. Thanks, Shaohua ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php