Re: Fw: ACPI, pm timer and ASUS a8v

[Shaohua Li <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Wed, 2005-09-21 at 01:30 -0700, Andrew Morton wrote:
> "Li, Shaohua" <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> >
> > >> How about add something like this:
> > >> if (fadt->revision >= FADT2_REVISION_ID) {
> > >> 		/* FADT rev. 2 */
> > >> 		if (fadt->xpm_tmr_blk.address_space_id !=
> > >> ACPI_ADR_SPACE_SYSTEM_IO)
> > >> 			return 0;
> > >>
> > >> 		pmtmr_ioport = fadt->xpm_tmr_blk.address;
> > >> +		if (!pmtmr_ioport)
> > >> +			pmtmr_ioport = fadt->V1_pm_tmr_blk;
> > >> 	} else {
> > >> 		/* FADT rev. 1 */
> > >> 		pmtmr_ioport = fadt->V1_pm_tmr_blk;
> > >> 	}
> > >
> > >this works
> > Great.
> > 
> > >
> > >ps.
> > >	I opened as andrew suggested a bug report:
> > >http://bugzilla.kernel.org/show_bug.cgi?id=5283
> > >ds.
> > Ok, I'll attach a formal patch into bugzilla.
> 
> Please email a copy?  I fear that patches which go into bugzilla never come
> out again ;)
> 
> At least, not sufficiently promptly.  We need to get fixups like this into
> mainline quickly.
Sure.
Handling FADT 2.0 xpmtmr address 0 case. The patch makes the pmtmr ioport
detecting align with ACPICA (the comments are copied from ACPICA code).

Signed-off-by: Shaohua Li<shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---

 linux-2.6.14-rc1-root/arch/i386/kernel/acpi/boot.c |    7 +++++++
 1 files changed, 7 insertions(+)

diff -puN arch/i386/kernel/acpi/boot.c~pm-tmr arch/i386/kernel/acpi/boot.c
--- linux-2.6.14-rc1/arch/i386/kernel/acpi/boot.c~pm-tmr	2005-09-21 16:17:23.000000000 +0800
+++ linux-2.6.14-rc1-root/arch/i386/kernel/acpi/boot.c	2005-09-21 16:20:05.000000000 +0800
@@ -642,6 +642,13 @@ static int __init acpi_parse_fadt(unsign
 			return 0;
 
 		pmtmr_ioport = fadt->xpm_tmr_blk.address;
+		/*
+		 * "X" fields are optional extensions to the original V1.0
+		 * fields, so we must selectively expand V1.0 fields if the
+		 * corresponding X field is zero.
+	 	 */
+		if (!pmtmr_ioport)
+			pmtmr_ioport = fadt->V1_pm_tmr_blk;
 	} else {
 		/* FADT rev. 1 */
 		pmtmr_ioport = fadt->V1_pm_tmr_blk;
_




-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. 
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php