Re: oops with asus_acpi on P30/P35

[Timo Hoenig <thoenig-dCxI//HcOdFeoWH0uzbU5w@public.gmane.org>]

Hi,

On Wed, 2005-09-21 at 11:08 +0200, Christian Aichinger wrote:

> OK, it's getting a little frustrating that this still isn't fixed.
> I've now written a patch that tests for ACPI_TYPE_INTEGER, and it
> tests for possible return values from P35's INIT.
> 
> Since the relevant part hasn't changed between P30 -> P35's DSDT, I
> assume that there has been some change in the Linux ACPI code, that
> causes integer returns now instead of no returns. This means we
> could get rid of the P30 code in the (!buffer.pointer) path. I don't
> have a P30 around to test this though :-/
> 
> I got the -1/0x58/0x38 values from my DSDT:
> INIT there calls WLED, which calls \_SB.PCI0.LPCB.EC0.STC5, last
> call with arg 0x58 or 0x38. That function then returns with either
> Ones (which I gathered is ~0, i.e. -1) or with Arg0. That's the last
> return that happens within the INIT call, so I thought that might be
> the result of the call as a whole.
> 
> That fits nicely, since 0x58 is really returned on my laptop.
> 
> If this fix still breaks other laptops I'd really be puzzled, since
> currently the value is dereferenced later when doing the string
> comparisons. So the patch at least shouldn't break it more than it
> already is ;)

I can confirm that your patch works fine for the W5A which previously
needed the mentioned workaround.  But this single case of success should
not be taken as proof.  More testing would be reasonable.

[...]

See you,

   Timo



-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. 
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php