RE: [RFC]convert ACPI driver model to Linux driver model - takes 2

[Shaohua Li <shaohua.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Thu, 2005-10-13 at 15:45 +0800, Yu, Luming wrote:
> >+static int __init acpi_phys_bus_init(void)
> >+{
> >+	bus_register(&acpi_phys_bus_type);
> >+
> >+	phys_root = kzalloc(sizeof(struct acpi_phys_device), 
> >GFP_KERNEL);
> >+	if (!phys_root)
> >+		return -ENOMEM;
> >+
> >+	phys_root->acpi_dev = acpi_root;
> >+	phys_root->phys_dev.release = acpi_phys_device_release;
> >+	sprintf(phys_root->phys_dev.bus_id, "%s", 
> >acpi_root->pnp.bus_id);
> >+	device_register(&phys_root->phys_dev);
> >+
> >+	/* enumerate devices */
> >+	acpi_bus_register_driver(&dummy_driver);
> >+	return 0;
> >+}
> 
> The structure is in a mess. why not cut bus.c?
> 
> I like this:
> 
> acpi_bus_init(void)
> {
> ...
> bus_register(&acpi_bus_type);
> ...
> driver_register(&acpi_bus_driver);
> ...
> }
I'm sorry, but I don't understand what do you mean. Can you clarify it?
Also, please focus on the basic idea of how to convert ACPI driver model
in current stage. It appears people have quite different opinions about
the topic. The code is just to show my idea (a RFC) not for merging, so
please ignore possible errors (Not everybody agrees with introducing
ACPI bus, actually). It's my bad not explain this.

Thanks,
Shaohua



-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl