Re: Re: [RFC]convert ACPI driver model to Linux driver model - takes 2

Re: Re: [RFC]convert ACPI driver model to Linux driver model - takes 2

[mika.penttila-9Aww8k/80nUxHbG02/KK1g]

> On Thu, 2005-10-13 at 11:18 +0300, mika.penttila-9Aww8k/80nUxHbG02/KK1g@public.gmane.org wrote:
> > >+/* this driver is linking acpi device with acpi phys device */
> > >+static struct acpi_driver dummy_driver = {
> > >+ .name = "acpi_dummy",
> > >+ /* List all ids of ACPI phys devices */
> > >+ .ids =
> > >+// "PNP0C09," /* EC */
> > >+// "ACPI0003," /* AC */
> > >+// "PNP0C0F," /* Link */
> > >+// "PNP0C0A," /* battery */
> > >+// "PNP0C0C,PNP0C0E,PNP0C0D,ACPI_FPB,ACPI_FSB," /* button */
> > >+// "PNP0C0B," /* fan */
> > >+// "PNP0A03," /* PCI root */
> > >+// ACPI_POWER_HID"," /* power */
> > >+// ACPI_PROCESSOR_HID"," /* CPU */
> > >+// ACPI_THERMAL_HID"," /* thermal */
> > >+ "",
> > >+ .ops = {
> > >+ .add = acpi_phys_bus_add,
> > >+ .remove = acpi_phys_bus_remove,
> > >+ },
> > >+};
> > 
> > Are those ids meant to be commented out in the dummy driver?
> The patch is just to show my idea not for merging, so there is some
> debug info. Please ignore them currently. I'm sorry I didn't mention
> this in previous email.
> 
> Thanks,
> Shaohua
> 
> 
That's ok, but the idea still is to list all ACPI phys devices there?

--Mika




-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

Re: Re: [RFC]convert ACPI driver model to Linux driver model - takes 2

[Shaohua Li]

On Thu, 2005-10-13 at 11:28 +0300, mika.penttila-9Aww8k/80nUxHbG02/KK1g@public.gmane.org wrote:
> > On Thu, 2005-10-13 at 11:18 +0300, mika.penttila-9Aww8k/80nUxHbG02/KK1g@public.gmane.org wrote:
> > > >+/* this driver is linking acpi device with acpi phys device */
> > > >+static struct acpi_driver dummy_driver = {
> > > >+ .name = "acpi_dummy",
> > > >+ /* List all ids of ACPI phys devices */
> > > >+ .ids =
> > > >+// "PNP0C09," /* EC */
> > > >+// "ACPI0003," /* AC */
> > > >+// "PNP0C0F," /* Link */
> > > >+// "PNP0C0A," /* battery */
> > > >+// "PNP0C0C,PNP0C0E,PNP0C0D,ACPI_FPB,ACPI_FSB," /* button */
> > > >+// "PNP0C0B," /* fan */
> > > >+// "PNP0A03," /* PCI root */
> > > >+// ACPI_POWER_HID"," /* power */
> > > >+// ACPI_PROCESSOR_HID"," /* CPU */
> > > >+// ACPI_THERMAL_HID"," /* thermal */
> > > >+ "",
> > > >+ .ops = {
> > > >+ .add = acpi_phys_bus_add,
> > > >+ .remove = acpi_phys_bus_remove,
> > > >+ },
> > > >+};
> > > 
> > > Are those ids meant to be commented out in the dummy driver?
> > The patch is just to show my idea not for merging, so there is some
> > debug info. Please ignore them currently. I'm sorry I didn't mention
> > this in previous email.
> > 
> > Thanks,
> > Shaohua
> > 
> > 
> That's ok, but the idea still is to list all ACPI phys devices there?
Yes. We could remove the comment after the driver converts to the new
style. We could do this one by one.

Thanks,
Shaohua



-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl