Re: [ACPI] Re: [Pcihpd-discuss] RE: [patch 2/2] acpi: add ability to derive irq when doing a surpriseremoval of an adapter

Bjorn Helgaas
2005-10-22T03:14:12Z

> pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin);
> +
> + /*
> + * If a device has been "surprise" removed via
> + * hotplug, the pin value will be invalid
> + * In this case, we should use the stored
> + * pin value from the pci_dev structure
> + */
> + if (pin == 0xff)
> + pin = dev->pin;

I think you should just always use dev->pin, and don't even
bother trying the pci_read_config_byte(). Fewer code paths
to worry about that way.

Bjorn