[patch request test] disable PIC/APIC/IOAPIC at S3 suspend

[patch request test] disable PIC/APIC/IOAPIC at S3 suspend

[Shaohua Li]

Hi,
Zwane submitted a patch for reboot bug here:
http://marc.theaimsgroup.com/?l=linux-kernel&m=113098129126352&w=2
I guess we need the same thing for S3 suspend/resume, as S3 also jumps
to BIOS. Could anybody with S3 failure try below patch?

Thanks,
Shaohua


---

 linux-2.6.14-root/arch/i386/kernel/apic.c    |    4 +++-
 linux-2.6.14-root/arch/i386/kernel/i8259.c   |    2 ++
 linux-2.6.14-root/arch/i386/kernel/io_apic.c |    1 +
 3 files changed, 6 insertions(+), 1 deletion(-)

diff -puN arch/i386/kernel/i8259.c~disalbe_some_devices arch/i386/kernel/i8259.c
--- linux-2.6.14/arch/i386/kernel/i8259.c~disalbe_some_devices	2005-11-09 14:11:04.000000000 +0800
+++ linux-2.6.14-root/arch/i386/kernel/i8259.c	2005-11-09 14:11:04.000000000 +0800
@@ -262,6 +262,8 @@ static int i8259A_resume(struct sys_devi
 static int i8259A_suspend(struct sys_device *dev, pm_message_t state)
 {
 	save_ELCR(irq_trigger);
+	outb(0xff, 0x21);	/* mask all of 8259A-1 */
+	outb(0xff, 0xA1);	/* mask all of 8259A-1 */
 	return 0;
 }
 
diff -puN arch/i386/kernel/io_apic.c~disalbe_some_devices arch/i386/kernel/io_apic.c
--- linux-2.6.14/arch/i386/kernel/io_apic.c~disalbe_some_devices	2005-11-09 14:11:04.000000000 +0800
+++ linux-2.6.14-root/arch/i386/kernel/io_apic.c	2005-11-09 14:11:04.000000000 +0800
@@ -2350,6 +2350,7 @@ static int ioapic_suspend(struct sys_dev
 		*(((int *)entry) + 0) = io_apic_read(dev->id, 0x10 + 2 * i);
 	}
 	spin_unlock_irqrestore(&ioapic_lock, flags);
+	disable_IO_APIC();
 	return 0;
 }
 
diff -puN arch/i386/kernel/apic.c~disalbe_some_devices arch/i386/kernel/apic.c
--- linux-2.6.14/arch/i386/kernel/apic.c~disalbe_some_devices	2005-11-09 14:13:26.000000000 +0800
+++ linux-2.6.14-root/arch/i386/kernel/apic.c	2005-11-09 14:17:57.000000000 +0800
@@ -612,7 +612,9 @@ static int lapic_suspend(struct sys_devi
 	apic_pm_state.apic_thmr = apic_read(APIC_LVTTHMR);
 
 	local_irq_save(flags);
-	disable_local_APIC();
+	clear_local_APIC();
+	if (enabled_via_apicbase)
+		disable_local_APIC();
 	local_irq_restore(flags);
 	return 0;
 }
_




-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php

Re: [patch request test] disable PIC/APIC/IOAPIC at S3 suspend

[Stefan Seyfried]

On Wed, Nov 09, 2005 at 02:40:31PM +0800, Shaohua Li wrote:
> Hi,
> Zwane submitted a patch for reboot bug here:
> http://marc.theaimsgroup.com/?l=linux-kernel&m=113098129126352&w=2
> I guess we need the same thing for S3 suspend/resume, as S3 also jumps
> to BIOS. Could anybody with S3 failure try below patch?

What kind of S3 failure? Failure to suspend or failure to resume?
-- 
Stefan Seyfried



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click

RE: Re: [patch request test] disable PIC/APIC/IOAPIC at S3 suspend

[Li, Shaohua]

Hi,
>-----Original Message-----
>From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
>admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Stefan Seyfried
>Sent: Friday, November 25, 2005 10:04 AM
>To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>Subject: Re: [ACPI] [patch request test] disable PIC/APIC/IOAPIC at S3
>suspend
>
>On Wed, Nov 09, 2005 at 02:40:31PM +0800, Shaohua Li wrote:
>> Hi,
>> Zwane submitted a patch for reboot bug here:
>> http://marc.theaimsgroup.com/?l=linux-kernel&m=113098129126352&w=2
>> I guess we need the same thing for S3 suspend/resume, as S3 also
jumps
>> to BIOS. Could anybody with S3 failure try below patch?
>
>What kind of S3 failure? Failure to suspend or failure to resume?
Sorry, I missed the email. I'm not sure about what kind of failure.
Just want to know if it changes anything in failure systems, as S3 also
enters BIOS. It's possible we suffer the same failure as Zwane.

Thanks,
Shaohua


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id\x16865&op=click

Re: [patch request test] disable PIC/APIC/IOAPIC at S3 suspend

[Stefan Seyfried]

On Tue, Nov 29, 2005 at 11:00:56AM +0800, Li, Shaohua wrote:
> 
> Hi,
> >-----Original Message-----
> >From: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:acpi-devel-
> >admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Stefan Seyfried

> >What kind of S3 failure? Failure to suspend or failure to resume?
> Sorry, I missed the email. I'm not sure about what kind of failure.
> Just want to know if it changes anything in failure systems, as S3 also
> enters BIOS. It's possible we suffer the same failure as Zwane.

ok, so it's probably systems failing to suspend (not "powering off" but
hanging instead). I have not come across this failure mode for some time
now, so i probably cannot help.
-- 
Stefan Seyfried


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click