asus_acpi oops on samsung p35

asus_acpi oops on samsung p35

[Sascha Sommer]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

Hi,

as the oops, reported for example in 
http://sourceforge.net/mailarchive/message.php?msg_id=11977633,
is still occuring on recent kernels it would be nice if someone could review 
the attached patch from Christian Aichinger posted to this list in
http://sourceforge.net/mailarchive/message.php?msg_id=13057151
so the remaining issues can be fixed.
It is working fine with my Samsung p35.


Thanks in advance

Sascha

[-- Attachment #2: asus_acpi.c.patch --]
[-- Type: text/x-diff, Size: 1548 bytes --]

diff --git a/drivers/acpi/asus_acpi.c b/drivers/acpi/asus_acpi.c
--- a/drivers/acpi/asus_acpi.c
+++ b/drivers/acpi/asus_acpi.c
@@ -1006,6 +1006,24 @@ static int __init asus_hotk_get_info(voi
 	}
 
 	model = (union acpi_object *)buffer.pointer;
+
+	/* INIT on Samsung's P35 returns an integer, possible return
+	 * values are tested below */
+	if (model->type == ACPI_TYPE_INTEGER) {
+		if (model->integer.value == -1 ||
+			model->integer.value == 0x58 ||
+			model->integer.value == 0x38) {
+			hotk->model = P30;
+			printk(KERN_NOTICE
+				       "  Samsung P35 detected, supported\n");
+			goto out_known;
+		} else {
+			printk(KERN_WARNING 
+				"  unknown integer returned by INIT\n");
+			goto out_unknown;
+		}
+	}
+
 	if (model->type == ACPI_TYPE_STRING) {
 		printk(KERN_NOTICE "  %s model detected, ",
 		       model->string.pointer);
@@ -1057,9 +1075,7 @@ static int __init asus_hotk_get_info(voi
 		hotk->model = L5x;
 
 	if (hotk->model == END_MODEL) {
-		printk("unsupported, trying default values, supply the "
-		       "developers with your DSDT\n");
-		hotk->model = M2E;
+		goto out_unknown;
 	} else {
 		printk("supported\n");
 	}
@@ -1088,6 +1104,15 @@ static int __init asus_hotk_get_info(voi
 	acpi_os_free(model);
 
 	return AE_OK;
+
+out_unknown:
+	printk(KERN_WARNING "  unsupported, trying default values, "
+			"supply the developers with your DSDT\n");
+	hotk->model = M2E;
+out_known:
+	hotk->methods = &model_conf[hotk->model];
+	acpi_os_free(model);
+	return AE_OK;
 }
 
 static int __init asus_hotk_check(void)

Re: asus_acpi oops on samsung p35

[Yu, Luming]

On Tuesday 22 November 2005 03:38, Sascha Sommer wrote:
> Hi,
>
> as the oops, reported for example in
> http://sourceforge.net/mailarchive/message.php?msg_id=11977633,
> is still occuring on recent kernels it would be nice if someone could
> review the attached patch from Christian Aichinger posted to this list in
> http://sourceforge.net/mailarchive/message.php?msg_id=13057151
> so the remaining issues can be fixed.
> It is working fine with my Samsung p35.

One question:  why you need asus_acpi.c ?

Does striking hotkeys on keyboard works for you?
Do you need to echo something to proc files
for hotkey function?

Thanks,
Luming


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click

Re: asus_acpi oops on samsung p35

[Sascha Sommer]

Hi,

On Friday 25 November 2005 07:43, Yu, Luming wrote:
> On Tuesday 22 November 2005 03:38, Sascha Sommer wrote:
> > Hi,
> >
> > as the oops, reported for example in
> > http://sourceforge.net/mailarchive/message.php?msg_id=11977633,
> > is still occuring on recent kernels it would be nice if someone could
> > review the attached patch from Christian Aichinger posted to this list in
> > http://sourceforge.net/mailarchive/message.php?msg_id=13057151
> > so the remaining issues can be fixed.
> > It is working fine with my Samsung p35.
>
> One question:  why you need asus_acpi.c ?
>
> Does striking hotkeys on keyboard works for you?
> Do you need to echo something to proc files
> for hotkey function?
>

With the asus_acpi module loaded the hotkeys can be used via acpid.
Without this volume control via hotkeys etc. won't work.
With asus_acpi loaded one can also switch of the lcd and control the wireless 
lan led.

Regards

Sascha


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click

Re: asus_acpi oops on samsung p35

[Timo Hoenig]

Hi,

On Fri, 2005-11-25 at 14:43 +0800, Yu, Luming wrote:

> On Tuesday 22 November 2005 03:38, Sascha Sommer wrote:
> > Hi,
> >
> > as the oops, reported for example in
> > http://sourceforge.net/mailarchive/message.php?msg_id=11977633,
> > is still occuring on recent kernels it would be nice if someone could
> > review the attached patch from Christian Aichinger posted to this list in
> > http://sourceforge.net/mailarchive/message.php?msg_id=13057151
> > so the remaining issues can be fixed.
> > It is working fine with my Samsung p35.
> 
> One question:  why you need asus_acpi.c ?
> 
> Does striking hotkeys on keyboard works for you?
> Do you need to echo something to proc files
> for hotkey function?

Please include the fix as asus_acpi.c is still part of the mainline
kernel.

The fix is extensively tested.  I've included a similar patch for SL
10.0 and had positive feedback of Samsung P3x users.  It did not bear
any side effects.

> Thanks,
> Luming

Thanks,

   Timo



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click