Re: [Pcihpd-discuss] [patch 2/4] acpiphp: handle dock bridges

Kenji Kaneshige
2006-01-18T04:46:39Z

Kristen Accardi wrote:
> +static acpi_status handle_dock(struct acpiphp_func *func, int dock)
> +{
> + acpi_status status;
> + struct acpi_object_list arg_list;
> + union acpi_object arg;
> + struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
> +
> + dbg("%s: enter\n", __FUNCTION__);
> +
> + /* _DCK method has one argument */
> + arg_list.count = 1;
> + arg_list.pointer = &arg;
> + arg.type = ACPI_TYPE_INTEGER;
> + arg.integer.value = dock;
> + status = acpi_evaluate_object(func->handle, "_DCK",
> + &arg_list, &buffer);
> + if (ACPI_FAILURE(status))
> + err("%s: failed to dock!!\n", MY_NAME);
> +
> + return status;
> +}

I think you need to add acpi_os_free() for freeing buffer.pointer.

Thanks,
Kenji Kaneshige