RE: [PATCH] amd76x_pm: C3 powersaving for AMD K7

[Erik Slagter <erik@slagter.name>]

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]

On Wed, 2006-02-01 at 13:11 -0500, Brown, Len wrote:
>  >>  This patch can also be found at
> >>  http://www.sommrey.de/amd76x_pm/amd76x_pm-2.6.15-4.patch
> >> 
> >>  In this version more locking was added to make sure all or 
> >>  no CPU enter C3 mode.
> >> 
> >>  Signed-off-by: Joerg Sommrey <jo@sommrey.de>
> >
> >Thanks.  I'll merge this into -mm and shall plague the ACPI 
> >guys with it. 
> >They have said discouraging things about board-specific drivers in the
> >past.  We shall see.
> 
> Linux/ACPI has had generic supported SMP deep (> C1) C-states
> for a few months now and AFAIK it is working fine.
> Why is a platform specific driver needed for these boards?

Boards with this chipset tend to have some timing in the DSDT wrong
which prevents ACPI te actually use the C2/C3 states. It seems that
C2/C3 can only be used on amd76x boards with some extra setup code.
Maybe it would be an idea to merge both pieces of code as much as
possible?

BTW there it looks like there is a bug in the linux SMP ACPI Cx code;
when I patch the code to "see" only valid timings, only one processor
shows states or than C1, the other only shows (and uses) C1.

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 2771 bytes --]