From: Kristen Accardi <kristen.c.accardi@intel.com>
To: "Brown, Len" <len.brown@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
greg@kroah.com, linux-acpi@vger.kernel.org,
pcihpd-discuss@lists.sourceforge.net,
linux-kernel@vger.kernel.org, mochel@linux.intel.com,
arjan@linux.intel.com, muneda.takahiro@jp.fujitsu.com,
pavel@ucw.cz, temnota@kmv.ru
Subject: RE: [patch 1/3] acpi: dock driver
Date: Fri, 14 Apr 2006 16:11:00 -0700 [thread overview]
Message-ID: <1145056260.29319.55.camel@whizzy> (raw)
In-Reply-To: <CFF307C98FEABE47A452B27C06B85BB6300EE2@hdsmsx411.amr.corp.intel.com>
On Fri, 2006-04-14 at 15:42 -0700, Brown, Len wrote:
> Re: indenting & white-space
>
> Please run the whole thing through the latest Lindent.
> It will delete the white space.
> It will do a couple of stupid things with indenting --
> such as with MODULE_AUTHOR --
> feel free to hand tweak those by hand.
>
> Re: acpi_os_free()
> Please call kfree() instead, that wrapper is intended
> just for the ACPICA core and although it appears symmetric,
> it really shouldn't be used outside drivers/acpi/*/*.c
Really? why is it exported then? We use this in drivers/pci/hotplug as
well, and it is all over the place in drivers/acpi. Should I be
modifying the hotplug drivers to not use this call?
next prev parent reply other threads:[~2006-04-14 23:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-14 22:42 [patch 1/3] acpi: dock driver Brown, Len
2006-04-14 23:11 ` Kristen Accardi [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-04-19 19:17 Moore, Robert
2006-04-19 17:51 Moore, Robert
2006-04-19 18:06 ` Patrick Mochel
2006-04-19 17:14 Moore, Robert
2006-04-19 17:36 ` Patrick Mochel
2006-04-14 23:17 Brown, Len
[not found] <20060412221027.472109000@intel.com>
2006-04-12 22:18 ` Kristen Accardi
2006-04-13 5:27 ` Andrew Morton
2006-04-14 22:02 ` Kristen Accardi
2006-04-14 22:49 ` Kristen Accardi
2006-04-15 14:29 ` Prarit Bhargava
2006-04-18 18:03 ` Kristen Accardi
2006-04-18 22:54 ` Patrick Mochel
2006-04-19 17:08 ` Kristen Accardi
2006-04-19 17:28 ` Patrick Mochel
2006-04-19 18:28 ` Kristen Accardi
2006-04-19 18:20 ` Patrick Mochel
2006-04-16 13:28 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145056260.29319.55.camel@whizzy \
--to=kristen.c.accardi@intel.com \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=greg@kroah.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@linux.intel.com \
--cc=muneda.takahiro@jp.fujitsu.com \
--cc=pavel@ucw.cz \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=temnota@kmv.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox