From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kristen Accardi Subject: RE: [patch 1/3] acpi: dock driver Date: Fri, 14 Apr 2006 16:11:00 -0700 Message-ID: <1145056260.29319.55.camel@whizzy> References: Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com ([134.134.136.20]:58647 "EHLO orsmga101-1.jf.intel.com") by vger.kernel.org with ESMTP id S1751296AbWDNXCW (ORCPT ); Fri, 14 Apr 2006 19:02:22 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Brown, Len" Cc: Andrew Morton , greg@kroah.com, linux-acpi@vger.kernel.org, pcihpd-discuss@lists.sourceforge.net, linux-kernel@vger.kernel.org, mochel@linux.intel.com, arjan@linux.intel.com, muneda.takahiro@jp.fujitsu.com, pavel@ucw.cz, temnota@kmv.ru On Fri, 2006-04-14 at 15:42 -0700, Brown, Len wrote: > Re: indenting & white-space > > Please run the whole thing through the latest Lindent. > It will delete the white space. > It will do a couple of stupid things with indenting -- > such as with MODULE_AUTHOR -- > feel free to hand tweak those by hand. > > Re: acpi_os_free() > Please call kfree() instead, that wrapper is intended > just for the ACPICA core and although it appears symmetric, > it really shouldn't be used outside drivers/acpi/*/*.c Really? why is it exported then? We use this in drivers/pci/hotplug as well, and it is all over the place in drivers/acpi. Should I be modifying the hotplug drivers to not use this call?