From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kristen Accardi Subject: Re: 2.6.17-rc4-mm3 - kernel panic Date: Fri, 26 May 2006 11:29:35 -0700 Message-ID: <1148668175.7600.11.camel@whizzy> References: <1148583675.3070.41.camel@whizzy> <20060525221222.GA1608@elf.ucw.cz> <20060525221744.GA1671@elf.ucw.cz> <1148601858.3070.62.camel@whizzy> <20060526071518.GC1699@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga03.intel.com ([143.182.124.21]:25902 "EHLO azsmga101-1.ch.intel.com") by vger.kernel.org with ESMTP id S1751232AbWEZSSL convert rfc822-to-8bit (ORCPT ); Fri, 26 May 2006 14:18:11 -0400 In-Reply-To: <20060526071518.GC1699@elf.ucw.cz> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Pavel Machek Cc: "Brown, Len" , Andreas Saur , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, 2006-05-26 at 09:15 +0200, Pavel Machek wrote: > On =C4=8Ct 25-05-06 17:04:18, Kristen Accardi wrote: > > On Fri, 2006-05-26 at 00:17 +0200, Pavel Machek wrote: > > > On P=C3=A1 26-05-06 00:12:22, Pavel Machek wrote: > > > > Hi! > > > >=20 > > > > > > Does the panic go away with CONFIG_ACPI_DOCK=3Dn? > > > >=20 > > > > > Can either Pavel or Andreas please try this little debugging = patch and > > > > > send me the dmesg output? Please enable the CONFIG_DEBUG_KER= NEL option > > > > > in your .config as well so that I can get additional info. > > > >=20 > > > > Yep, you were right... this debugging patch helps. > > >=20 > > > ...and docking +/- works, but it does not look like PCI in dockin= g > > > station is properly connected: > > >=20 > >=20 > > No, I would not expect PCI to work properly with the debug patch - > > basically all I did was prevent the oops and confirm that this is t= he > > issue, I did not actually solve the problem. > >=20 > > I need some way to prevent acpiphp from loading before dock is comp= leted > > it's init. > >=20 > > I guess I will think about this some more. >=20 > Using different _init levels? Like putting dock at subsys_initcall() > while acpiphp at late_initcall()? > Pavel Can you see if this works for you? Revert the first debug patch I sent and apply this one instead (against -mm). Thanks, Kristen --- drivers/acpi/dock.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- 2.6-mm.orig/drivers/acpi/dock.c +++ 2.6-mm/drivers/acpi/dock.c @@ -190,6 +190,9 @@ static int is_dock(acpi_handle handle) */ int is_dock_device(acpi_handle handle) { + if (!dock_station) + return 0; + if (is_dock(handle) || find_dock_dependent_device(dock_station, handl= e)) return 1; =20 @@ -674,5 +677,5 @@ static void __exit dock_exit(void) dock_remove(); } =20 -module_init(dock_init); +postcore_initcall(dock_init); module_exit(dock_exit); - To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html