Re: [Lhms-devel] [RFC] Patch [1/2] for acpi_memhotplug.c

[keith mannthey <kmannth@us.ibm.com>]

On Thu, 2006-06-22 at 10:58 +0900, KAMEZAWA Hiroyuki wrote:
> On Wed, 21 Jun 2006 18:37:00 -0700
> keith mannthey <kmannth@us.ibm.com> wrote:
> 
> > > in acpi_bus_driver_init()
> > > - driver->ops.add() is called or not
> > > - what it retruns
> > 
> > It is called.  But that is not the whole story.  
> > In acpi_bus_driver_init it calls driver->ops.add(device). This ops.add
> > is not acpi_memory_device_add.  I do get not any printks that I would
> > expect from acpi_memory_device_add.   
> > 
> > If I print out in acpi_bus_driver_init
> >  printk(" device_add() about %s\n",acpi_device_name(device));
> >  result = driver->ops.add(device);
> > 
> Good Catch :)
> 
> Then, could you print driver name ? like this
> ==
> printk("Call Add driver for name %s/class %s/id %s\n",driver->name,driver->class,driver->id);
> ==

Good idea!
During the hot add I see. 
Call Add driver for name motherboard/class /id PNP0C01

That is the wrong driver for sure. 
> 
> > Maybe I am picking the wrong driver from list_for_each_safe(node, next, &acpi_bus_drivers) 
> > in acpi_bus_find_driver?
> > 
> looks so...BTW, your acpi_memhotplug driver is a module or built-in ?
Built-in. 

Thanks. 
-- 
keith mannthey <kmannth@us.ibm.com>
Linux Technology Center IBM