From: Thomas Renninger <trenn@suse.de>
To: Alexey Starikovskiy <alexey_y_starikovskiy@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, "Brown, Len" <len.brown@intel.com>,
acpi4asus-user@lists.sourceforge.net
Subject: Re: [PATCH] Repost: asus strict model checking
Date: Wed, 02 Aug 2006 12:00:20 +0200 [thread overview]
Message-ID: <1154512820.4302.444.camel@queen.suse.de> (raw)
In-Reply-To: <44CF92EB.4010801@linux.intel.com>
On Tue, 2006-08-01 at 21:44 +0400, Alexey Starikovskiy wrote:
> Thomas Renninger wrote:
> > On Tue, 2006-08-01 at 20:11 +0400, Alexey Starikovskiy wrote:
> >> Checks for Samsung P30/P35 are real hacks IMHO.
> > Why?
> Because this DSDT signature could appear on any machine, and has nothing to do
> with ASUS or Samsung.
The string seems to define how the ATKD ACPI device has to be used.
If this Device pops up on other machines than Asus it's fine.
AFAIK the mappings from the string returned by ATKD.INIT and how the
device has to be used then works fine.
It's probably much better than the way done on Thinkpads:
If we have ACPI func xy we assume to have an A21 or similar and use this
set of function/variables.
I consider this an ugly hack:
IBM_HANDLE(ec, root, "\\_SB.PCI0.ISA.EC0", /* 240, 240x */
"\\_SB.PCI.ISA.EC", /* 570 */
"\\_SB.PCI0.ISA0.EC0", /* 600e/x, 770e, 770x */
"\\_SB.PCI0.ISA.EC", /* A21e, A2xm/p, T20-22, X20-21 */
"\\_SB.PCI0.AD4S.EC0", /* i1400, R30 */
"\\_SB.PCI0.ICH3.EC0", /* R31 */
"\\_SB.PCI0.LPC.EC", /* all others */
On Asus we should be happy ATKD.INIT is returning something useful and
one can guess (be sure?) which ACPI functions to use for what.
Checking for that string and making use of different ACPI
variable/method names seems to be intended and looks like the defined
way this should be used. As long as this is not officially specified (by
ACPI consortium and/or vendors) and such special Devices exist, it is
the best we can do.
Thomas
next prev parent reply other threads:[~2006-08-02 9:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 13:15 [PATCH] Repost: asus strict model checking Thomas Renninger
2006-08-01 13:58 ` Alexey Starikovskiy
2006-08-01 15:29 ` Thomas Renninger
2006-08-01 16:11 ` Alexey Starikovskiy
2006-08-01 17:22 ` Thomas Renninger
2006-08-01 17:44 ` Alexey Starikovskiy
2006-08-02 10:00 ` Thomas Renninger [this message]
2006-08-02 18:49 ` Alexey Starikovskiy
2006-08-03 8:40 ` Thomas Renninger
2006-08-02 16:00 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2006-08-02 20:12 Brown, Len
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154512820.4302.444.camel@queen.suse.de \
--to=trenn@suse.de \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=alexey_y_starikovskiy@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox