From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Renninger Subject: Re: [PATCH 2/2] acpi,backlight: MSI S270 laptop support - driver Date: Tue, 15 Aug 2006 14:42:16 +0200 Message-ID: <1155645736.4302.1161.camel@queen.suse.de> References: <20060810010517.GA20849@curacao> Reply-To: trenn@suse.de Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:1495 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S932775AbWHOMho (ORCPT ); Tue, 15 Aug 2006 08:37:44 -0400 In-Reply-To: <20060810010517.GA20849@curacao> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Lennart Poettering Cc: len.brown@intel.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org On Thu, 2006-08-10 at 03:05 +0200, Lennart Poettering wrote: > From: Lennart Poettering > > > +config ACPI_MSI_S270 > + tristate "MSI S270 Laptop Extras" > + depends on X86 > + depends on BACKLIGHT_CLASS_DEVICE > + ---help--- > + This is a Linux ACPI driver for MSI S270 laptops. It adds > + support for Bluetooth, WLAN and LCD brightness control. > + > + More information about this driver is available at > + . > + > + If you have an MSI S270 laptop, say Y or M here. I don't know anything about MSI laptops. But S270 sounds like a very specific model to me? Shouldn't the driver just be called acpi_msi driver and try to also support other MSI models later that might do things at least similar? Thomas