From: Adam Belay <abelay@novell.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: len.brown@intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@dominikbrodowski.net,
arjan@linux.intel.com
Subject: Re: [RFC][PATCH 2/2] ACPI: handle timer ticks proactively
Date: Tue, 05 Sep 2006 11:16:00 -0400 [thread overview]
Message-ID: <1157469360.3420.14.camel@localhost.localdomain> (raw)
In-Reply-To: <20060905090328.GA4888@elf.ucw.cz>
On Tue, 2006-09-05 at 11:03 +0200, Pavel Machek wrote:
> Hi!
>
> > > > This patch takes advantage of the infrastructure introduced in the last
> > > > patch, and allows the processor idle algorithm to proactively choose a
> > > > c-state based on the time the next timer interrupt is expected to occur.
> > > > It preserves the residency metric, so the algorithm should, in theory,
> > > > remain effective against bursts of activity from other interrupt
> > > > sources.
> > > >
> > > > This patch is mostly intended to be illustrative. There may be some
> > > > "#ifdef CONFIG_ACPI" issues, and I would appreciate any advice on
> > > > implementing this more cleanly.
> >
> > Okay, just to get you some feedback:
> >
> > It seems to change things a _lot_. Power consumption with usb modules
> > loaded went from 14315mW to 13800mW -- that is huge
> > deal. Unfortunately something strange is going on: with stock kernel,
> > power consumption is mostly constant. With your patch, it varies a
> > lot, at 2 second timescale.
> >
> > Power consumption with usb unloaded (only way to get reasonable power
> > on x60) went from stable 10450mW to something rapidly changing, and
> > probably even worse than original:
>
> I also noticed that with your patch, bus master activity tends to be constant?!
Is this the case even when userspace touches the disk? On my hardware I
see a constant flow of short BM activity bursts.
Thanks,
Adam
next prev parent reply other threads:[~2006-09-05 15:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060904131027.GD6279@ucw.cz>
2006-09-05 8:28 ` [RFC][PATCH 2/2] ACPI: handle timer ticks proactively Pavel Machek
2006-09-05 8:53 ` Pavel Machek
2006-09-05 9:03 ` Pavel Machek
2006-09-05 15:16 ` Adam Belay [this message]
2006-09-06 10:54 ` Pavel Machek
2006-08-29 20:51 Adam Belay
2006-10-16 4:59 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157469360.3420.14.camel@localhost.localdomain \
--to=abelay@novell.com \
--cc=arjan@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox