Re: [0/12] acpi: make ACPI use driver model

Henrique de Moraes Holschuh
2006-11-24T14:33:53Z

On Fri, 24 Nov 2006, Henrique de Moraes Holschuh wrote:
> On Fri, 24 Nov 2006, Zhang Rui wrote:
> > The problem is the driver name "ibm/hotkey".
> > '/' and "\0" can not exist in an kobject->name.
> > In driver/acpi/ibm_acpi.c line 1828, please replace the '/' with '-' or
> > any other character and try again :)
>
> ACK. Patch to fix this throughout ibm-acpi being written right now.

I spoke too soon, line 1828 must *NOT* be changed or it will change
userspace ABI, instantly breaking every ibm-acpi acpid hotkey scripts out
there.

The ibm-acpi hotkey events are named "ibm/hotkey" (to follow the convention
"button/power", etc. I suppose). Changing line 1828 changes them to
something else.

Are you sure what you need isn't to change line 1857, which deals with
acpi_bus_register_driver?

I will reply with a patch.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh