public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@rpsys.net>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: benh@kernel.crashing.org, paulus@samba.org,
	Lennart Poettering <mzxreary@0pointer.de>,
	Andriy Skulysh <askulysh@image.kiev.ua>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	Antonino Daplas <adaplas@pol.net>, Holger Macht <hmacht@suse.de>
Subject: Re: [PATCH] backlight: do not power off backlight when unregistering (try 2)
Date: Fri, 10 Nov 2006 10:44:40 +0000	[thread overview]
Message-ID: <1163155480.5550.0.camel@localhost.localdomain> (raw)
In-Reply-To: <20061110003237.GB9021@khazad-dum.debian.net>

On Thu, 2006-11-09 at 22:32 -0200, Henrique de Moraes Holschuh wrote:
> ACPI drivers like ibm-acpi are moving to the backlight sysfs infrastructure.
> During ibm-acpi testing, I have noticed that backlight_device_unregister()
> sets the display brightness and power to zero.
> 
> This causes the display to be dimmed on ibm-acpi module removal.  It will
> affect all other ACPI drivers that are being converted to use the backlight
> class, as well.  It also affects a number of framebuffer devices that are
> used on desktops and laptops which might also not want such behaviour.
> 
> Since working around this behaviour requires undesireable hacks, Richard
> Purdie decided that we would be better off reverting the changes in the
> sysfs class, and adding the code to dim and power off the backlight device
> to the drivers that want it.  This patch is my attempt to do so.
> 
> Patch against latest linux-2.6.git.  Changes untested, as I lack the
> required hardware.  Still, they are trivial enough that, apart from typos,
> there is little chance of getting them wrong.
> 
> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: Andriy Skulysh <askulysh@image.kiev.ua>
> Cc: Antonino Daplas <adaplas@pol.net>
Acked-by: Richard Purdie <rpurdie@rpsys.net>


  reply	other threads:[~2006-11-10 10:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-05 22:54 [PATCH] backlight: do not power off backlight when unregistering Henrique de Moraes Holschuh
2006-11-06  0:36 ` Richard Purdie
2006-11-06  1:26   ` Henrique de Moraes Holschuh
2006-11-10  0:08   ` Henrique de Moraes Holschuh
2006-11-10  0:32     ` [PATCH] backlight: do not power off backlight when unregistering (try 2) Henrique de Moraes Holschuh
2006-11-10 10:44       ` Richard Purdie [this message]
2006-11-20 19:31     ` [PATCH] backlight: do not power off backlight when unregistering James Simmons
2006-11-21  3:01       ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1163155480.5550.0.camel@localhost.localdomain \
    --to=rpurdie@rpsys.net \
    --cc=adaplas@pol.net \
    --cc=askulysh@image.kiev.ua \
    --cc=benh@kernel.crashing.org \
    --cc=hmacht@suse.de \
    --cc=hmh@hmh.eng.br \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mzxreary@0pointer.de \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox