Re: problems about ACPI sysfs convert work

Zhang Rui
2006-11-22T08:10:22Z

On Tue, 2006-11-21 at 16:34 +0000, Matthew Garrett wrote:
> (I seem to be missing the original mail here...)
>
> On Mon, Nov 20, 2006 at 12:18:13PM +0100, Thomas Renninger wrote:
> > > Hello, lists
> > > I’m doing the ACPI sysfs convert work now. And I have some problems when duplicating some procfs interfaces to sysfs.
> > > Under driver model (this will be available soon), files under /proc/acpi/xxx(driver)/yyy(device)/ will be duplicated under /sys/device/ as they are properties of individual devices.
> > > But I still have some trouble on dealing with the files under /prco/acpi, including “alarm”, “sleep”, “wakeup”, “debug_layer”, “debug_level”, “dsdt”, “fadt”, “event” and “info”.
> > > Following is a proposal as well as some problem and I’m not quite sure about the places all these attributes should be located at. I wish to get some advice from you, and any comment is welcome☺.
> > >
> > > 1. Where should “alarm” be located? Another problem is whether we should put a duration into this file instead of a future time.
> > Don't know, never used...
>
> This should presumably just be handled by the clock driver rather than
> the ACPI subsystem. There's only a tiny amount of acpi-related code in
> the driver, and that's information that we could just export to the
> clock instead.
>
I prefer to locate "alarm" under /sys/power, together with "wakeup".
Yes, you are right that it does have a lot to do with the clock driver.
But I think this patch series should impact other parts little. You
know, the main purpose of this patch series is just to duplicate the
procfs function in sysfs. So only the functions for sysfs interface will
be added in the first step. :)