Re: [PATCH 01/21] ACPI: ibm-acpi: do not use / in driver names

[Zhang Rui <rui.zhang@intel.com>]

On Sat, 2006-11-25 at 18:42 -0200, Henrique de Moraes Holschuh wrote:
> From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> 
> ibm-acpi uses sub-device names like ibm/hotkey, which get in the way of
> a sysfs conversion.  Fix it to use ibm_hotkey instead.  Thanks to Zhang
> Rui for noticing this.
> 
> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> ---
> 
>  drivers/acpi/ibm_acpi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/acpi/ibm_acpi.c b/drivers/acpi/ibm_acpi.c
> index 9658253..9baae34 100644
> --- a/drivers/acpi/ibm_acpi.c
> +++ b/drivers/acpi/ibm_acpi.c
> @@ -1854,7 +1854,7 @@ static int __init register_driver(struct
>  	}
>  
>  	memset(ibm->driver, 0, sizeof(struct acpi_driver));
> -	sprintf(ibm->driver->name, "%s/%s", IBM_NAME, ibm->name);
> +	sprintf(ibm->driver->name, "%s_%s", IBM_NAME, ibm->name);
>  	ibm->driver->ids = ibm->hid;
>  	ibm->driver->ops.add = &ibm_device_add;
>  
I think this patch should be added to ACPI sysfs patch series, as it's
critical for ACPI sysfs conversion. We should make sure that the patches
won't break ibm_acpi any longer. :)