linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: malattia@linux.it
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, Mattia Dongili <malattia@linux.it>
Subject: [PATCH 11/11] Fix sony_acpi backlight registration and unregistration
Date: Sat, 13 Jan 2007 23:04:41 +0100	[thread overview]
Message-ID: <11687258822382-git-send-email-malattia@linux.it> (raw)
In-Reply-To: <11687258813008-git-send-email-malattia@linux.it>

From: Mattia Dongili <malattia@linux.it>

Initialize the current brightness if the driver registration
was successful and unregister the driver in the error exit path.

Signed-off-by: Mattia Dongili <malattia@linux.it>
---
 drivers/acpi/sony_acpi.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/sony_acpi.c b/drivers/acpi/sony_acpi.c
index c65f589..c01d98d 100644
--- a/drivers/acpi/sony_acpi.c
+++ b/drivers/acpi/sony_acpi.c
@@ -354,9 +354,14 @@ static int sony_acpi_add(struct acpi_device *device)
 	if (ACPI_SUCCESS(acpi_get_handle(sony_acpi_handle, "GBRT", &handle))) {
 		sony_backlight_device = backlight_device_register("sony", NULL,
 					NULL, &sony_backlight_properties);
+
 	        if (IS_ERR(sony_backlight_device)) {
         	        printk(LOG_PFX "unable to register backlight device\n");
+			sony_backlight_device = NULL;
 		}
+		else
+			sony_backlight_properties.brightness =
+				sony_backlight_get_brightness(sony_backlight_device);
 	}
 
 	for (item = sony_acpi_values; item->name; ++item) {
@@ -400,6 +405,9 @@ static int sony_acpi_add(struct acpi_device *device)
 	return 0;
 
 outproc:
+	if (sony_backlight_device)
+		backlight_device_unregister(sony_backlight_device);
+
 	for (item = sony_acpi_values; item->name; ++item)
 		if (item->proc)
 			remove_proc_entry(item->name, acpi_device_dir(device));
-- 
1.4.4.2


  reply	other threads:[~2007-01-13 22:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-13 22:04 [PATCH 0/11] sony_acpi: prepare for prime time (resend) malattia
2007-01-13 22:04 ` [PATCH 1/11] SNC device support for Sony Vaios malattia
2007-01-13 22:04   ` [PATCH 2/11] Avoid dimness on resume malattia
2007-01-13 22:04     ` [PATCH 3/11] Fix sony_acpi_resume call malattia
2007-01-13 22:04       ` [PATCH 4/11] Add backlight support to the sony_acpi malattia
2007-01-13 22:04         ` [PATCH 5/11] Add backlight support to the sony_acpi v2 malattia
2007-01-13 22:04           ` [PATCH 6/11] Video sysfs support take 2 malattia
2007-01-13 22:04             ` [PATCH 7/11] Add acpi_bus_generate event malattia
2007-01-13 22:04               ` [PATCH 8/11] Allow easier debugging for the unknown SNC methods malattia
2007-01-13 22:04                 ` [PATCH 9/11] Add lanpower and audiopower controls malattia
2007-01-13 22:04                   ` [PATCH 10/11] Allow multiple sony_acpi_values for the same .name malattia
2007-01-13 22:04                     ` malattia [this message]
2007-01-15  9:01 ` [PATCH 0/11] sony_acpi: prepare for prime time (resend) Luming Yu
2007-01-15 19:12   ` Mattia Dongili
2007-01-17  5:50     ` Luming Yu
2007-01-17  9:34       ` Mattia Dongili

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11687258822382-git-send-email-malattia@linux.it \
    --to=malattia@linux.it \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).