From: Len Brown <len.brown@intel.com>
To: linux-acpi@vger.kernel.org
Cc: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>,
Len Brown <len.brown@intel.com>
Subject: [PATCH 2/9] ACPI: resolve HP nx6125 S3 immediate wakeup regression
Date: Tue, 20 Mar 2007 11:27:04 -0400 [thread overview]
Message-ID: <11744044323692-git-send-email-len.brown@intel.com> (raw)
Message-ID: <1d99967badac599c0d1db0b45c99e073e8e98cd4.1174404136.git.len.brown@intel.com> (raw)
In-Reply-To: <11744044323719-git-send-email-len.brown@intel.com>
In-Reply-To: <a1fdcc0d2714b6622e3fd5c00db1635213d6c41a.1174404136.git.len.brown@intel.com>
From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
Moving disable GPEs from enter_sleep up into sleep_prepare fixed
the disabled SCI on S4 on Acer laptops.
However, it caused an immediate S3 resume on the HP nx6125.
Apparently, on the HP, a GPE was getting re-enabled after
the prepare, but before the enter.
Close that window by restoring the GPE disable on enter.
This is redundant in most cases, but closes this window,
where S3 and S4 paths differ.
Signed-off-by: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Acked-by: Ray Lee <ray-lk@madrabbit.org>
---
drivers/acpi/hardware/hwsleep.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/hardware/hwsleep.c b/drivers/acpi/hardware/hwsleep.c
index 8fa9312..c84b1fa 100644
--- a/drivers/acpi/hardware/hwsleep.c
+++ b/drivers/acpi/hardware/hwsleep.c
@@ -300,6 +300,11 @@ acpi_status asmlinkage acpi_enter_sleep_state(u8 sleep_state)
/*
* 2) Enable all wakeup GPEs
*/
+ status = acpi_hw_disable_all_gpes();
+ if (ACPI_FAILURE(status)) {
+ return_ACPI_STATUS(status);
+ }
+
acpi_gbl_system_awake_and_running = FALSE;
status = acpi_hw_enable_all_wakeup_gpes();
--
1.5.0.3.382.g34572
next prev parent reply other threads:[~2007-03-20 15:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 15:27 ACPI patches for release onto Linux-2.6.21-rc4 Len Brown
[not found] ` <a1fdcc0d2714b6622e3fd5c00db1635213d6c41a.1174404136.git.len.brown@intel.com>
2007-03-20 15:27 ` [PATCH 1/9] ACPI: Add support to parse 2nd MADT Len Brown
[not found] ` <1d99967badac599c0d1db0b45c99e073e8e98cd4.1174404136.git.len.brown@intel.com>
2007-03-20 15:27 ` Len Brown [this message]
[not found] ` <5b18167d6b7c63e2787cd9a68f0620a9c363fc85.1174404136.git.len.brown@intel.com>
2007-03-20 15:27 ` [PATCH 3/9] sony-laptop: MAINTAINERS fix entry, add L: and W: Len Brown
[not found] ` <a8f4af6dc6600980885c594f52eecd60edd62013.1174404136.git.len.brown@intel.com>
2007-03-20 15:27 ` [PATCH 4/9] ACPICA: revert "acpi_serialize" changes Len Brown
[not found] ` <09fe58356d148ff66901ddf639e725ca1a48a0af.1174404137.git.len.brown@intel.com>
2007-03-20 15:27 ` [PATCH 5/9] ACPI: parse 2nd MADT by default Len Brown
[not found] ` <96e89afe6da630dc54cfbca33c2c6a7ab9b6c11b.1174404137.git.len.brown@intel.com>
2007-03-20 15:27 ` [PATCH 6/9] ACPI: ibm-acpi: allow module to load when acpi notifiers can't be set (v2) Len Brown
[not found] ` <25496caec111481161e7f06bbfa12a533c43cc6f.1174404137.git.len.brown@intel.com>
2007-03-20 15:27 ` [PATCH 7/9] ACPI: Only use IPI on known broken machines (AMD, Dothan/BaniasPentium M) Len Brown
[not found] ` <8140a90ec180192b202af086e7a582e5937c5580.1174404137.git.len.brown@intel.com>
2007-03-20 15:27 ` [PATCH 8/9] ACPI: IA64: fix allnoconfig build Len Brown
[not found] ` <0cd4554df0c261f7ba74786e471ccaa0e3725fb9.1174404137.git.len.brown@intel.com>
2007-03-20 15:27 ` [PATCH 9/9] ACPI: IA64: fix %ll build warnings Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11744044323692-git-send-email-len.brown@intel.com \
--to=len.brown@intel.com \
--cc=alexey.y.starikovskiy@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).