Re: [patch 2.6.21-rc5-git 0/3] x86_pc and ACPI support /sys/devices/.../wakeup

[Zhang Rui <rui.zhang@intel.com>]

Hi, David,

On Thu, 2007-04-05 at 12:48 -0700, David Brownell wrote:
> Following are three patches for basic driver model wakeup flag support on
> PCs.  I think the first two are nearly mergable.  The third previously broke
> powerpc, so it's likely not yet mergeable ... the issue was arch-specific
> differences in PCI initialization, someone else will need to solve them.
> 
> The patches are:
> 
>  - Define a platform_enable_wakeup() PM hook and use it with PCI.  (This
>    might help OLPC with its non-RTC events...)
> 
>  - Make ACPI init and use driver model wakeup flags for the (motherboard)
>    devices in its table ... and implement that new platform hook.  Now
>    /proc/acpi/wakeup is almost purely informative.
> 
Yes.
But /proc/acpi/wakeup is exporting the wrong information then.
I.e. when a physical device is set to may_wakeup, the corresponding GPE
will be enabled before entering a system sleep state.
But we always get status of the ACPI device is disabled
via /proc/acpi/wakeup, even if they could be enabled in
acpi_platform_enable_wakeup when suspending.

Thanks,
Rui