From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhang Rui Subject: Re: [patch 2.6.21-rc5-git 0/3] x86_pc and ACPI support /sys/devices/.../wakeup Date: Wed, 18 Apr 2007 17:51:06 +0800 Message-ID: <1176889866.5376.34.camel@localhost.localdomain> References: <200704051248.40745.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com ([192.55.52.88]:12267 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422751AbXDRJwF (ORCPT ); Wed, 18 Apr 2007 05:52:05 -0400 In-Reply-To: <200704051248.40745.david-b@pacbell.net> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: David Brownell Cc: linux-pm@lists.linux-foundation.org, "linux-acpi@vger" Hi, David, On Thu, 2007-04-05 at 12:48 -0700, David Brownell wrote: > Following are three patches for basic driver model wakeup flag support on > PCs. I think the first two are nearly mergable. The third previously broke > powerpc, so it's likely not yet mergeable ... the issue was arch-specific > differences in PCI initialization, someone else will need to solve them. > > The patches are: > > - Define a platform_enable_wakeup() PM hook and use it with PCI. (This > might help OLPC with its non-RTC events...) > > - Make ACPI init and use driver model wakeup flags for the (motherboard) > devices in its table ... and implement that new platform hook. Now > /proc/acpi/wakeup is almost purely informative. > Yes. But /proc/acpi/wakeup is exporting the wrong information then. I.e. when a physical device is set to may_wakeup, the corresponding GPE will be enabled before entering a system sleep state. But we always get status of the ACPI device is disabled via /proc/acpi/wakeup, even if they could be enabled in acpi_platform_enable_wakeup when suspending. Thanks, Rui